TypeError -> ValueError

jeremiedbb · jeremiedbb · commit c8246f2549dd · 2018-06-20T15:23:36.000+02:00
diff --git a/sklearn/impute.py b/sklearn/impute.py
@@ -219,9 +219,9 @@ def fit(self, X, y=None):
         if (self.strategy == "constant" and
                 X.dtype.kind in ("i", "u", "f") and
                 not isinstance(fill_value, numbers.Real)):
-            raise TypeError("'fill_value'={0} is invalid. Expected a numerical"
-                            " value when imputing numerical"
-                            " data".format(fill_value))
+            raise ValueError("'fill_value'={0} is invalid. Expected a "
+                             "numerical value when imputing numerical "
+                             "data".format(fill_value))
 
         if sparse.issparse(X):
             self.statistics_ = self._sparse_fit(X,
diff --git a/sklearn/tests/test_impute.py b/sklearn/tests/test_impute.py
@@ -319,7 +319,7 @@ def test_imputation_constant_error_invalid_type(X_data, missing_value):
     X = np.full((3, 5), X_data)
     X[0, 0] = missing_value
 
-    with pytest.raises(TypeError, match="imputing numerical"):
+    with pytest.raises(ValueError, match="imputing numerical"):
         imputer = SimpleImputer(missing_values=missing_value,
                                 strategy="constant",
                                 fill_value="x")
