Patch out SYRK portions in GEMM

jakirkham · jakirkham · commit e2dd7b88920a · 2018-08-23T15:14:07.000-04:00
The GEMM functions in ATLAS's reference BLAS will detect if a matrix is
being multiplied by its transpose and if so dispatch to SYRK. While a
good idea, it is much more complicated to pull in the SYRK portions of
ATLAS as they have some headers and source files that are generated
dynamically at build time. Given our changes here do not benefit from
SYRK, simply patch out those custom dispatch portions in the GEMM
functions.
diff --git a/sklearn/src/cblas/cblas_dgemm.c b/sklearn/src/cblas/cblas_dgemm.c
@@ -139,18 +139,6 @@ void cblas_dgemm(const enum CBLAS_ORDER Order,
       return;
    }
 #endif
-/*
- * Call SYRK when that's what the user is actually asking for; just handle
- * beta=0, because beta=X requires we copy C and then subtract to preserve
- * asymmetry
- */
-   if (A == B && M == N && TA != TB && lda == ldb && beta == 0.0)
-   {
-      ATL_dsyrk(CblasUpper, (Order == CblasColMajor) ? TA : TB, N, K,
-                alpha, A, lda, beta, C, ldc);
-      ATL_dsyreflect(CblasUpper, N, C, ldc);
-      return;
-   }
    if (Order == CblasColMajor)
       ATL_dgemm(TA, TB, M, N, K, alpha, A, lda, B, ldb, beta, C, ldc);
    else
diff --git a/sklearn/src/cblas/cblas_sgemm.c b/sklearn/src/cblas/cblas_sgemm.c
@@ -139,18 +139,6 @@ void cblas_sgemm(const enum CBLAS_ORDER Order,
       return;
    }
 #endif
-/*
- * Call SYRK when that's what the user is actually asking for; just handle
- * beta=0, because beta=X requires we copy C and then subtract to preserve
- * asymmetry
- */
-   if (A == B && M == N && TA != TB && lda == ldb && beta == 0.0)
-   {
-      ATL_ssyrk(CblasUpper, (Order == CblasColMajor) ? TA : TB, N, K,
-                alpha, A, lda, beta, C, ldc);
-      ATL_ssyreflect(CblasUpper, N, C, ldc);
-      return;
-   }
    if (Order == CblasColMajor)
       ATL_sgemm(TA, TB, M, N, K, alpha, A, lda, B, ldb, beta, C, ldc);
    else
