MAINT: Changed default 'percent10' to True in fetch_kddcup99

Nikolay Mayorov · Nikolay Mayorov · commit f57887420f79 · 2015-12-11T20:13:09.000+05:00
diff --git a/sklearn/datasets/kddcup99.py b/sklearn/datasets/kddcup99.py
@@ -40,7 +40,7 @@
 
 
 def fetch_kddcup99(subset=None, shuffle=False, random_state=None,
-                   percent10=False, download_if_missing=True):
+                   percent10=True, download_if_missing=True):
     """Load and return the kddcup 99 dataset (classification).
 
     The KDD Cup '99 dataset was created by processing the tcpdump portions
diff --git a/sklearn/datasets/tests/test_kddcup99.py b/sklearn/datasets/tests/test_kddcup99.py
@@ -12,31 +12,30 @@
 
 def test_percent10():
     try:
-        data = fetch_kddcup99(download_if_missing=False, percent10=True)
+        data = fetch_kddcup99(download_if_missing=False)
     except IOError as e:
         if e.errno == errno.ENOENT:
             raise SkipTest("kddcup99 dataset can not be loaded.")
 
     assert_equal(data.data.shape, (494021, 41))
     assert_equal(data.target.shape, (494021,))
 
-    data_shuffled = fetch_kddcup99(shuffle=True, random_state=0,
-                                   percent10=True)
+    data_shuffled = fetch_kddcup99(shuffle=True, random_state=0)
     assert_equal(data.data.shape, data_shuffled.data.shape)
     assert_equal(data.target.shape, data_shuffled.target.shape)
 
-    data = fetch_kddcup99('SA', percent10=True)
+    data = fetch_kddcup99('SA')
     assert_equal(data.data.shape, (100655, 41))
     assert_equal(data.target.shape, (100655,))
 
-    data = fetch_kddcup99('SF', percent10=True)
+    data = fetch_kddcup99('SF')
     assert_equal(data.data.shape, (73237, 4))
     assert_equal(data.target.shape, (73237,))
 
-    data = fetch_kddcup99('http', percent10=True)
+    data = fetch_kddcup99('http')
     assert_equal(data.data.shape, (58725, 3))
     assert_equal(data.target.shape, (58725,))
 
-    data = fetch_kddcup99('smtp', percent10=True)
+    data = fetch_kddcup99('smtp')
     assert_equal(data.data.shape, (9571, 3))
     assert_equal(data.target.shape, (9571,))
