Run linter once (with a recent version) instead of multiple times (with inconsistent versions) #31047
DimitriPapadopoulos
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
CI runs the linter multiple times without any visible reason, using different versions of the tools and sometimes even different configurations. Perhaps a leftover from previous linters, the behaviour of which might have depended on the version of Python they run on?
scikit-learn/.circleci/config.yml
Line 17 in 225b1e3
scikit-learn/azure-pipelines.yml
Line 41 in 225b1e3
scikit-learn/.github/workflows/arm-unit-tests.yml
Line 32 in 225b1e3
scikit-learn/.github/workflows/lint.yml
Line 49 in 225b1e3
scikit-learn/.pre-commit-config.yaml
Lines 11 to 13 in 225b1e3
Suggestions:
black
/ruff
/mypy
only once, because the result should not depend on the platform or version of Python.pre-commit
instead of directly executing these tools, so that the same version and configuration are used locally on the programmers' machines when runningpre-commit
and during CI.As a first step towards this goal, I have tried to homogenize the versions of
black
/ruff
/mypy
, using recent versions:This should address previous discussions on the subject:
Comments?
Beta Was this translation helpful? Give feedback.
All reactions