Skip to content

minmax_scale does not ignore NaNs #11239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
glemaitre opened this issue Jun 11, 2018 · 4 comments · Fixed by #11243
Closed

minmax_scale does not ignore NaNs #11239

glemaitre opened this issue Jun 11, 2018 · 4 comments · Fixed by #11243

Comments

@glemaitre
Copy link
Member

The class MinMaxScaler ignore NaNs. Its counterpart function does not.

The check_array needs to add the option force_all_finite='allow-nan'.
#11206 implement the tests and this fix. However, it should be done in another proper PR.
@jnothman
Copy link
Member

jnothman commented Jun 12, 2018 via email

@glemaitre
Copy link
Member Author

Kinda, some changes are not necessary.

@jnothman
Copy link
Member

jnothman commented Jun 12, 2018 via email

@glemaitre glemaitre mentioned this issue Jun 12, 2018
Merged
@glemaitre
Copy link
Member Author

There is some stuff linked to the standardscaler.
I opened #11243 to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] EHN ignore nan in minmax_scale glemaitre/scikit-learn
2 participants
@jnothman @glemaitre