Skip to content

BUG: check_cv check for cv is 'warn' instead of cv == 'warn' which is raising an exception with n_jobs=-1 #12154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
glemaitre opened this issue Sep 25, 2018 · 1 comment · Fixed by #12155
Closed

BUG: check_cv check for cv is 'warn' instead of cv == 'warn' which is raising an exception with n_jobs=-1 #12154

glemaitre opened this issue Sep 25, 2018 · 1 comment · Fixed by #12155
Labels
Blocker
Milestone
0.20

Comments

@glemaitre
Copy link
Member

glemaitre commented Sep 25, 2018 •
edited
Loading

In _split.py, cv is 'warn' will not work as intended since cv will be copied if n_jobs=-1.

from sklearn.datasets import load_iris                                               
from sklearn.model_selection import GridSearchCV                                     
from sklearn.model_selection import cross_validate                                   
from sklearn.svm import SVC                                                          
                                                                                     
X, y = load_iris(return_X_y=True)                                                    
clf = SVC(gamma='auto')                                                              
grid = GridSearchCV(clf, param_grid={'C': [1, 10]}, iid=False)                       
score = cross_validate(grid, X, y,                                                   
                       n_jobs=-1,                                                    
                       cv=5, error_score='raise')  # to remove deprecation warning
ValueError: Expected cv as an integer, cross-validation object (from sklearn.model_selection) or an iterable. Got warn.
@glemaitre glemaitre mentioned this issue Sep 25, 2018
Merged
@glemaitre glemaitre added this to the 0.20 milestone Sep 25, 2018
@jnothman
Copy link
Member

I have to get the lgtm.com alerts back on.

@jnothman jnothman mentioned this issue Sep 26, 2018
Closed
@qinhanmin2014 qinhanmin2014 mentioned this issue Sep 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Blocker
Projects
None yet
Milestone
0.20
Development

Successfully merging a pull request may close this issue.

[MRG] BUG: check equality instead of identity in check_cv glemaitre/scikit-learn
2 participants
@jnothman @glemaitre