Skip to content

Inconsistent function parameter default value and documentation #12921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bertbesser opened this issue Jan 4, 2019 · 2 comments · Fixed by #12925
Closed

Inconsistent function parameter default value and documentation #12921

bertbesser opened this issue Jan 4, 2019 · 2 comments · Fixed by #12925

Comments

@bertbesser
Copy link

Description

In gradient_boosting.py the function update_terminal_regions for each of classes LossFunction and LeastSquaresError has a parameter learning_rate with default value 1.0. However, the default value is documented as 0.1.

Expected Results

I believe the default value should be 0.1

Actual Results

The default value is 1.0

Versions

commit 952ef66
@qinhanmin2014
Copy link
Member

Maybe you can take some time to finish #6463.

@qinhanmin2014 qinhanmin2014 mentioned this issue Jan 4, 2019
Merged
@qinhanmin2014
Copy link
Member

I've submitted a PR to finish that one, thanks for the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX learning_rate default value in update_terminal_regions
2 participants
@bertbesser @qinhanmin2014