Skip to content

[0.20.2] test_decode_anneal fails on ARM processors #13049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
olebole opened this issue Jan 27, 2019 · 2 comments
Closed

[0.20.2] test_decode_anneal fails on ARM processors #13049

olebole opened this issue Jan 27, 2019 · 2 comments
Assignees
Labels
Milestone

Comments

@olebole
Copy link

olebole commented Jan 27, 2019

Splitting #13036: On arm64 and armel platforms (ARM, 32 and 64 bit, little endian) and on alpha, I get the following failure in version 0.20.1 and 0.20.2:

monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0xffff8ac04790>

    def test_decode_anneal(monkeypatch):
        data_id = 2
        _monkey_patch_webbased_functions(monkeypatch, data_id, False)
>       _test_features_list(data_id)

sklearn/datasets/tests/test_openml.py:336: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

data_id = 2

    def _test_features_list(data_id):
        [...]
        for i in range(len(data_bunch.feature_names)):
            # XXX: Test per column, as this makes it easier to avoid problems with
            # missing values
    
            np.testing.assert_array_equal(data_downloaded[:, i],
>                                         decode_column(data_bunch, i))
E           AssertionError: 
E           Arrays are not equal
E           
E           (mismatch 100.0%)
E            x: array([None, None, None, None, None, None, None, None, None, None, None],
E                 dtype=object)
E            y: array(['GB', 'GB', 'GB', 'GB', 'GB', 'GB', 'GB', 'GB', 'GB', 'GB', 'GB'],
E                 dtype=object)

sklearn/datasets/tests/test_openml.py:65: AssertionError
@rth rth added the Bug label Jan 27, 2019
@rth rth added this to the 0.20.3 milestone Jan 27, 2019
@jnothman
Copy link
Member

So this feature should come out of _arff.py entirely filled with NaN, but it is being decoded in the test as if it consists of 0.

Has _arff.py been patched at all??

@jnothman jnothman self-assigned this Feb 25, 2019
@rth
Copy link
Member

rth commented Feb 25, 2019

@jnothman This one can be reproduced on ARM 64bit if it helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants