Skip to content

RFC/MAINT: refactor and common tests for estimator supporting string (object dtype) #13063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
glemaitre opened this issue Jan 29, 2019 · 4 comments
Open

RFC/MAINT: refactor and common tests for estimator supporting string (object dtype) #13063

glemaitre opened this issue Jan 29, 2019 · 4 comments
Labels
Developer API Third party developer API related module:test-suite everything related to our tests RFC

Comments

@glemaitre
Copy link
Member

Following #13046, we have redundant code in estimator which should support string dtype (object dtype). Those estimators should make similar validation and raise consistent errors and have (a) common test(s).

The estimators which are involved will be:

  • SimpleImputer
  • MissingIndicator
  • OneHotEncoder
  • OrdinalEncoder

I open this issue such that we can agree on the way to refactor this part.
@amueller
Copy link
Member

amueller commented Jan 29, 2019 •
edited
Loading

estimator tags should allow us to specify different training data for the estimators. I think that's the way to go.

@glemaitre
Copy link
Member Author

So you propose to make a common test based on the X_types.

@amueller Do you need more review on #8022, it seems almost good to be merged last time I checked?

@amueller
Copy link
Member

No, I propose to make all common tests use the X_types to figure out what training data to use. Right now most checks can't be performed for, say, CountVectorizer (or OneHotEncoder) because we can't train it because all the tests use float data for fitting.

re review: Not sure, I think @rth was reviewing.

@jnothman
Copy link
Member

jnothman commented Jan 31, 2019 via email

@cmarmo cmarmo added module:test-suite everything related to our tests RFC labels Feb 16, 2022
@adrinjalali adrinjalali added the Developer API Third party developer API related label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Developer API Third party developer API related module:test-suite everything related to our tests RFC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jnothman @amueller @cmarmo @adrinjalali @glemaitre