Skip to content

LassoLarsIC is missing Xy from its fit method signature which is present in parent parent method. #14145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Kibugu opened this issue Jun 22, 2019 · 4 comments
Open

LassoLarsIC is missing Xy from its fit method signature which is present in parent parent method. #14145

Kibugu opened this issue Jun 22, 2019 · 4 comments
Labels
API module:linear_model Needs Decision Requires decision

Comments

@Kibugu
Copy link

Kibugu commented Jun 22, 2019 •
edited
Loading

Investigating issue no #12167. Mismatch between signature and use of an overridden method. Source root/sklearn/linear_model/least_angle.py

The fit function signature in LassoLarsIC is not matching the signature of the fit function in the Lars class which its inheriting from.

Should we continue and introduce XY on the method signature on LassoLarsIC on the fit method.
#WiMLDS
@adrinjalali
Copy link
Member

The parent class (Lars) accepts Xy to its fit, which is the precomputed gram matrix. The question is, should the child class also expose that as a parameter?

@reshamas
Copy link
Member

@Mariam-ke
Here are some options:

  1. If you want to work on this PR, you can.
  2. Can you find someone who was at the Nairobi sprint who would be able complete this?
  3. We can remove "Sprint" label and set it as "Help Wanted"

@adrinjalali adrinjalali added Needs Decision Requires decision and removed Sprint labels Jul 12, 2019
@adrinjalali
Copy link
Member

I changed the label @reshamas , this probably will take a long time to be done.

@reshamas
Copy link
Member

thanks @adrinjalali.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API module:linear_model Needs Decision Requires decision
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@adrinjalali @reshamas @thomasjpfan @lorentzenchr @Kibugu