Skip to content

Documentation for CountVectorizer suggests strange bounds for max_df param #18803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nschmeller opened this issue Nov 10, 2020 · 0 comments · Fixed by #25489
Closed

Documentation for CountVectorizer suggests strange bounds for max_df param #18803

nschmeller opened this issue Nov 10, 2020 · 0 comments · Fixed by #25489
Labels
Documentation module:feature_extraction

Comments

@nschmeller
Copy link

nschmeller commented Nov 10, 2020 •
edited
Loading

Describe the issue linked to the documentation

In the documentation for CountVectorizer stop_words replacement with max_df, max_df is suggested to have bounds [0.7, 1.0).

But, the documentation for max_df allows bounds from 0 to 1.

This seems a little strange! Is the 0.7 suggested to stop the user from doing crazy things with max_df? Or is this old?

Suggest a potential alternative/fix

Should there be consistency?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation module:feature_extraction
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DOC make max_df range consistent in CountVectorizer rprkh/scikit-learn
2 participants
@cmarmo @nschmeller