Skip to content

Clean up install script for documentation generation #20026

Closed
@glemaitre

Description

@glemaitre

In the script that build the documentation: build_tools/circle/build_doc.sh, we have the following line:

source activate testenv
pip install sphinx-gallery
pip install numpydoc
pip install sphinx-prompt

Indeed, the build doc-min-dependencies check that we build the documentation with a minimum version. However, these lines bypass this purpose. However the file sklearn/_min_dependencies.py are defining minimum version for these packages:

'sphinx-gallery': ('0.7.0', 'docs'),
'numpydoc': ('1.0.0', 'docs'),
'Pillow': ('7.1.2', 'docs'),
'sphinx-prompt': ('1.3.0', 'docs'),

I think that we should as well take into consideration the minimum version when installing these packages.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions