Skip to content

CI with boundscheck=False #21668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lorentzenchr opened this issue Nov 14, 2021 · 2 comments · Fixed by #21779
Closed

CI with boundscheck=False #21668

lorentzenchr opened this issue Nov 14, 2021 · 2 comments · Fixed by #21779
Labels
Build / CI cython

Comments

@lorentzenchr
Copy link
Member

I really dislike segmentation faults! Unfortunately, there are many issues reporting them.
Findings in #21654, #21283 were easier with setting boundscheck = True.

Proposition
Set up one CI configuration that runs with boundscheck = True globally which should be easier now that #21512 is merged.
@glemaitre
Copy link
Member

I think that one of @ogrisel @jeremiedbb @jjerphan had suggested such changes. We did not know if it was necessary or not. But your current experience shows that we should do that :)

@jeremiedbb
Copy link
Member

Good idea. I'd even switch initializedcheck and nonecheck to True

@thomasjpfan thomasjpfan mentioned this issue Nov 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build / CI cython
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MNT Configures boundscheck=True for one of the CI instances thomasjpfan/scikit-learn
3 participants
@glemaitre @lorentzenchr @jeremiedbb