Skip to content

Include an informative error message in check_scalar for inconsistent inputs #21948

@reshamas

Description

@reshamas

Check consistency between min, max and boundaries. In the check_scalar function, it is possible to:

  • specify a minimum and also say that include_boundaries="right"
  • specify a maximum and say include_boundaries="left"
  • check all permutations

There is an error message, but it is not informative. Update the code so the error message checks and gives an informative error.

Begin by testing various combinations and seeing what the error messages are.


Note for Beginners

Here are notes on how to get started:

  1. Read the documentation: https://scikit-learn.org/stable/developers/contributing.html
  2. Read notes on Git: https://www.dataschool.io/how-to-contribute-on-github/
  3. Watch videos: https://www.youtube.com/playlist?list=PLBKcU7Ik-ir-b1fwjNabO3b8ebs9ez5ga
  4. Go through the code base, explore it and find the file(s) where the edits need to be made.
  5. Read Stack Overflow's "How do I ask a good question?"
  6. Be inclusive in your communications: inclusive language
    • Do not use salutations such as "Hello Sir", or "Hey guys" (Why: these terms exclude women and non-binary people.)
    • Do not use salutations such as "Hello Sir/Madam" (Why: these terms assume gender is binary, and they exclude non-binary people.)

Note that due to limited resources, it may take many days before we can review your pull request. Please be patient, and if you don't receive any feedback within two weeks, you can give us a reminder on gitter.

Metadata

Metadata

Assignees

Labels

EasyWell-defined and straightforward way to resolvemodule:utils

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions