Skip to content

⚠️ CI failed on Linux_Nightly.pylatest_pip_scipy_dev ⚠️ #23531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scikit-learn-bot opened this issue Jun 3, 2022 · 11 comments
Closed
Labels
Needs Triage Issue requires triage

Comments

@scikit-learn-bot
Copy link
Contributor

scikit-learn-bot commented Jun 3, 2022

CI is still failing on Linux_Nightly.pylatest_pip_scipy_dev

  • test_missing_value_handling[est0-maxabs_scale-True-False-omit_kwargs0]
  • test_missing_value_handling[est3-scale-True-False-omit_kwargs3]
  • test_missing_value_handling[est6-quantile_transform-True-False-omit_kwargs6]
  • test_missing_value_handling[est8-robust_scale-True-False-omit_kwargs8]
@github-actions github-actions bot added the Needs Triage Issue requires triage label Jun 3, 2022
@glemaitre
Copy link
Member

Apparently, we don't have the equivalence dense-sparse anymore.

@ogrisel
Copy link
Member

ogrisel commented Jun 7, 2022

I deleted the redundant comments. They should no longer appear now that #23539 was merged: the description was edited by the bot 4 hours ago, so it seems to work as intended.

@ogrisel
Copy link
Member

ogrisel commented Jun 7, 2022

All failures appear with the DIAgonal sparse matrix format. The same assertions with CSR / CSC do seem to pass.

I will try to craft a minimal reproducer and report upstream.

@ogrisel
Copy link
Member

ogrisel commented Jun 7, 2022

The problem happens at fit time, the scale_ attribute of RobustScaler has different values for the DIAgonal input data:

dense [1.35  0.525 3.55  1.65 ]
csr [1.35  0.525 3.55  1.65 ]
csc [1.35  0.525 3.55  1.65 ]
bsr [1.35  0.525 3.55  1.65 ]
coo [1.35  0.525 3.55  1.65 ]
dia [1.4 0.7 3.6 1.6]

@ogrisel
Copy link
Member

ogrisel commented Jun 7, 2022

Ok, I found a minimal reproducer:

import numpy as np
import scipy.sparse as sp


X = np.ones(shape=(13, 4))
X[0, 0] = np.nan
print(sp.csc_matrix(X).indptr)
print(sp.csc_matrix(sp.dia_matrix(X)).indptr)

out:

[ 0 13 26 39 52]
[ 0 12 25 38 51]

@ogrisel
Copy link
Member

ogrisel commented Jun 7, 2022

I updated scipy/scipy#16365 with a more minimal reproducer.

@WarrenWeckesser
Copy link

FYI: The bug is actually in NumPy: numpy/numpy#21685

@ogrisel
Copy link
Member

ogrisel commented Jun 7, 2022

FYI: The bug is actually in NumPy: numpy/numpy#21685

Thanks. I should have checked I could reproduce with the latest stable numpy before reporting to scipy.

@scikit-learn-bot
Copy link
Contributor Author

CI is no longer failing! ✅

Successful run

@lesteve
Copy link
Member

lesteve commented Jun 9, 2022

Closing this one, I am guessing this did not get closed automatically because auto-close is off by default since #23155

@lesteve lesteve closed this as completed Jun 9, 2022
@ogrisel
Copy link
Member

ogrisel commented Jun 10, 2022

@thomasjpfan this bot is really cool :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Triage Issue requires triage
Projects
None yet
Development

No branches or pull requests

5 participants