-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
⚠️ CI failed on Linux_Nightly.pylatest_pip_scipy_dev ⚠️ #23531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Apparently, we don't have the equivalence dense-sparse anymore. |
I deleted the redundant comments. They should no longer appear now that #23539 was merged: the description was edited by the bot 4 hours ago, so it seems to work as intended. |
All failures appear with the DIAgonal sparse matrix format. The same assertions with CSR / CSC do seem to pass. I will try to craft a minimal reproducer and report upstream. |
The problem happens at fit time, the
|
Ok, I found a minimal reproducer: import numpy as np
import scipy.sparse as sp
X = np.ones(shape=(13, 4))
X[0, 0] = np.nan
print(sp.csc_matrix(X).indptr)
print(sp.csc_matrix(sp.dia_matrix(X)).indptr) out:
|
I updated scipy/scipy#16365 with a more minimal reproducer. |
FYI: The bug is actually in NumPy: numpy/numpy#21685 |
Thanks. I should have checked I could reproduce with the latest stable numpy before reporting to scipy. |
CI is no longer failing! ✅ |
Closing this one, I am guessing this did not get closed automatically because auto-close is off by default since #23155 |
@thomasjpfan this bot is really cool :) |
CI is still failing on Linux_Nightly.pylatest_pip_scipy_dev
The text was updated successfully, but these errors were encountered: