Skip to content

Make penalty parameter consistent for None #23749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
glemaitre opened this issue Jun 24, 2022 · 4 comments · Fixed by #23877
Closed

Make penalty parameter consistent for None #23749

glemaitre opened this issue Jun 24, 2022 · 4 comments · Fixed by #23877
Labels
API

Comments

@glemaitre
Copy link
Member

We are inconsistent with the penalty parameter for the linear models.
For the SGD and Perceptron, we will accept penalty=None while this is not the case in LogisticRegression. In LogisticRegression, we must provide the string 'none'.

I assume we could make everything consistent by accepting both None and 'none'.

@jeremiedbb WDYT?
@github-actions github-actions bot added the Needs Triage Issue requires triage label Jun 24, 2022
@glemaitre
Copy link
Member Author

The test can be easily handled by the common validation parameter if we decorate properly the estimator.

@jeremiedbb
Copy link
Member

I assume we could make everything consistent by accepting both None and 'none'

I'd just accept None but it would require a deprecation cycle so no strong opinion

@glemaitre glemaitre mentioned this issue Jun 24, 2022
Merged
@glemaitre
Copy link
Member Author

So it means that we would deprecate and ask to use None in LogisticRegression.

@thomasjpfan thomasjpfan added API Needs Decision - API and removed Needs Triage Issue requires triage labels Jun 30, 2022
@thomasjpfan
Copy link
Member

I'm okay with the deprecation here and go with None.

@MaxwellLZH MaxwellLZH mentioned this issue Jul 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

API deprecate penalty='none' for LogisticRegression MaxwellLZH/scikit-learn
3 participants
@thomasjpfan @glemaitre @jeremiedbb