Skip to content

Deprecate n_iter in favor of max_iter for consistency #25518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
glemaitre opened this issue Jan 31, 2023 · 5 comments · Fixed by #25697
Closed

Deprecate n_iter in favor of max_iter for consistency #25518

glemaitre opened this issue Jan 31, 2023 · 5 comments · Fixed by #25697

Comments

@glemaitre
Copy link
Member

BayesianRidge and ARDRegression are exposing the parameter n_iter instead of max_iter as in other models. I think that we should deprecate n_iter and rename it max_iter to be consistent.

@github-actions github-actions bot added the Needs Triage Issue requires triage label Jan 31, 2023
@glemaitre glemaitre removed the Needs Triage Issue requires triage label Jan 31, 2023
@saucam
Copy link

saucam commented Feb 4, 2023

@glemaitre I would like to attempt this one !

@glemaitre
Copy link
Member Author

@saucam please go ahead and propose a pull-request. You can refer to the following documentation page to follow our deprecation rule: https://scikit-learn.org/dev/developers/contributing.html#deprecation

@jpangas
Copy link
Contributor

jpangas commented Feb 20, 2023

@saucam ,let me know incase you need help. We can work together on this issue if it is fine with you.

@saucam
Copy link

saucam commented Feb 28, 2023

@jpangas sorry but I lost track of this one. You can go ahead with your changes as it looks like you already have some progress.

@jpangas
Copy link
Contributor

jpangas commented Feb 28, 2023

Thank you for getting back to me. I am working on the changes, should be done within the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants