Skip to content

Appears that the checking of deprecated attributes in turn causing issues #25881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
qstar2024 opened this issue Mar 16, 2023 · 5 comments
Closed

Appears that the checking of deprecated attributes in turn causing issues #25881

qstar2024 opened this issue Mar 16, 2023 · 5 comments
Labels
Needs Triage Issue requires triage

Comments

@qstar2024
Copy link

qstar2024 commented Mar 16, 2023 •
edited
Loading

image

##########
environment info

Microsoft Windows [Version 10.0.19045.2604]
(c) Microsoft Corporation. All rights reserved.

C:\WINDOWS\system32>pip show scikit-learn
Name: scikit-learn
Version: 1.2.2
Summary: A set of python modules for machine learning and data mining
Home-page: http://scikit-learn.org
Author:
Author-email:
License: new BSD
Location: c:\program files\python3\lib\site-packages
Requires: joblib, numpy, scipy, threadpoolctl
Required-by: ffn, lazypredict, lightgbm, shap

C:\WINDOWS\system32>python --version
Python 3.10.8

C:\WINDOWS\system32>
@github-actions github-actions bot added the Needs Triage Issue requires triage label Mar 16, 2023
@qstar2024 qstar2024 changed the title Appears that the checking or deprecated attributes in turn causing issues Appears that the checking of deprecated attributes in turn causing issues Mar 16, 2023
@jeremiedbb
Copy link
Member

Hi @tqiu592, can you provide a minimal reproducible example ?

@betatim
Copy link
Member

betatim commented Mar 17, 2023

I think #25668 might be related/relevant context.

@qstar2024
Copy link
Author

Hi @tqiu592, can you provide a minimal reproducible example ?

Whoops - my bad. I rushed to revert the scikit-learn version back to 1.1.x, and the codes no longer complaining. So I might not be able to generate the same error message as in the screenshot above.

But essentially this is an compatibility issue I guess, which arose when the RandomForestRegressor class calling the new base file in 1.2.2 version is attempting to wrap up the old attributes "self.estimator_" vs new attribute "self.estimator", the checking code on line 156 actually using the self.estimator, which doesn't exist in the old version of RFRegressor (it only has self.estimator_ ). hence the error message above.

@qstar2024
Copy link
Author

I think #25668 might be related/relevant context.

Yes, that looks super relevant, but maybe the fixes didn't go in the v1.2.2 release? (Or perhaps, it hasn't fully address the issue yet?)

@adrinjalali
Copy link
Member

Closing for lack of a reproducible. Happy to re-open if a reproducible is provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Triage Issue requires triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@betatim @adrinjalali @jeremiedbb @qstar2024