Skip to content

⚠️ CI failed on Linux_Nightly.pylatest_pip_scipy_dev ⚠️ #27578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
scikit-learn-bot opened this issue Oct 13, 2023 · 1 comment · Fixed by #27628
Closed

⚠️ CI failed on Linux_Nightly.pylatest_pip_scipy_dev ⚠️ #27578

scikit-learn-bot opened this issue Oct 13, 2023 · 1 comment · Fixed by #27628

Comments

@scikit-learn-bot
Copy link
Contributor

scikit-learn-bot commented Oct 13, 2023 •
edited
Loading

CI is still failing on Linux_Nightly.pylatest_pip_scipy_dev (Oct 20, 2023)

  • test_singular_matrix
@github-actions github-actions bot added the Needs Triage Issue requires triage label Oct 13, 2023
@lesteve
Copy link
Member

lesteve commented Oct 16, 2023

The test_singular_matrix one is probably due to scipy using upstream SuperLU code scipy/scipy#19284. This seems to change the behaviour slightly.

In particular, the following snippet raises RuntimeError: Factor is exactly singular with the latest scipy release but does not error with scipy dev:

import numpy as np
from scipy import sparse

arr = np.array([
    [ 2.5,  1.5, -0.5, -0.5, -0.5, -0.5, -0.5, -0.5, -0.5, -0.5],
    [ 1.5,  2.5, -0.5, -0.5, -0.5, -0.5, -0.5, -0.5, -0.5, -0.5],
    [-0.5, -0.5,  1. ,  0. ,  0. ,  0. ,  0. ,  0. ,  0. ,  0. ],
    [-0.5, -0.5,  0. ,  1. ,  0. ,  0. ,  0. ,  0. ,  0. ,  0. ],
    [-0.5, -0.5,  0. ,  0. ,  1. ,  0. ,  0. ,  0. ,  0. ,  0. ],
    [-0.5, -0.5,  0. ,  0. ,  0. ,  1. ,  0. ,  0. ,  0. ,  0. ],
    [-0.5, -0.5,  0. ,  0. ,  0. ,  0. ,  1. ,  0. ,  0. ,  0. ],
    [-0.5, -0.5,  0. ,  0. ,  0. ,  0. ,  0. ,  1. ,  0. ,  0. ],
    [-0.5, -0.5,  0. ,  0. ,  0. ,  0. ,  0. ,  0. ,  1. ,  0. ],
    [-0.5, -0.5,  0. ,  0. ,  0. ,  0. ,  0. ,  0. ,  0. ,  1. ]])

matrix = sparse.csc_matrix(arr)

sparse.linalg.eigsh(matrix, 2, sigma=0.0, tol=1e-6, maxiter=100)

Not sure if this is an unwanted change from Scipy or this is something we should adapt to on our side.

The minibatch_sensible_reassign[34] has been seen elsewhere e.g. #26802 so it does not seem to be scipy-dev specific.

@betatim betatim removed the Needs Triage Issue requires triage label Oct 19, 2023
@lesteve lesteve mentioned this issue Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TST Fix locally_linear_embedding test with scipy-dev lesteve/scikit-learn
3 participants
@betatim @lesteve @scikit-learn-bot