-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
ENH: use the sparse-sparse backend for computing pairwise distance #28191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm under the impression that having a large number of features is something that was not taken into account when benchmarking in #24556 |
I confirm that nearly all the time (>99%) is spent in |
FYI, I'm running a larger benchmark for different |
How likely is it to have this fixed pretty quickly? I wonder how realistic it is to include it in 1.4.1 |
A quick fix is to change the definition of |
|
First reported in: scikit-learn-contrib/imbalanced-learn#1056
We have a regression in
kneighbors
with sparse matrix from 1.1.X to 1.3.X.A code sample to reproduce:
1.1.X
main
Small benchmark
Debug profiling
My first investigation look like we are spending all our time in the following function:
scikit-learn/sklearn/metrics/_pairwise_distances_reduction/_middle_term_computer.pyx.tp
Lines 39 to 69 in 5c7e831
But I'm a bit rusty with profiling native code. I need a bit more time to investigate.
The text was updated successfully, but these errors were encountered: