Skip to content

API Deprecate n_alphas in LinearModelCV #30467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeremiedbb opened this issue Dec 11, 2024 · 3 comments · Fixed by #30616
Closed

API Deprecate n_alphas in LinearModelCV #30467

jeremiedbb opened this issue Dec 11, 2024 · 3 comments · Fixed by #30616
Labels
API RFC

Comments

@jeremiedbb
Copy link
Member

jeremiedbb commented Dec 11, 2024 •
edited
Loading

In LassoCV, ElasticNetCV, ... we have two parameters, alphas and n_alphas, that have the same purpose, i.e. determine the alpha values to test.

I'd be in favor of deprecating n_alphas and make alphas accept either an int or an array-like, filling both roles.

I chose to keep alphas and not the other because RidgeCV has alphas and no n_alphas (although alphas can't be an int there, maybe an enhancement to make ?), and the most recent param of this kind, threshold in TunedThresholdClassifierCV, follows this naming pattern and fills both roles.
@KANNAHWORLD
Copy link
Contributor

Hi, can I take a shot at refactoring?

@jeremiedbb
Copy link
Member Author

sure ! You can take a look at the contributing guide and especially the deprecation section to get started.

@KANNAHWORLD KANNAHWORLD mentioned this issue Jan 9, 2025
Merged
@KANNAHWORLD
Copy link
Contributor

@jeremiedbb Just created a PR, I believe it is linked. I followed the contributing guidelines to the best of my abilities, but happy to make any changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes API Deprecate n_alphas in LinearModelCV KANNAHWORLD/scikit-learn
2 participants
@jeremiedbb @KANNAHWORLD