Skip to content

Revisit dtype="numeric" #4685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amueller opened this issue May 7, 2015 · 1 comment
Closed

Revisit dtype="numeric" #4685

amueller opened this issue May 7, 2015 · 1 comment
Labels
API Enhancement

Comments

@amueller
Copy link
Member

amueller commented May 7, 2015

I introduced check_array(X, dtype="numeric") to handle dtype=object gracefully in #4057.
In #4645 @TomDLT added much more fine-grained control over dtypes.

We should revisit if the "numeric" ever adds anything, or if we want to always be more explicit about whether we want integers or floats.
@amueller amueller mentioned this issue May 7, 2015
Merged
3 tasks
@amueller
Copy link
Member Author

amueller commented Nov 5, 2019

I think we can close this for now. This helps for object and string stuff I think.

@amueller amueller closed this as completed Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amueller