Skip to content

[BUG?] CalibratedClassifierCV is not marked as a meta-estimator #5518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ainafp opened this issue Oct 21, 2015 · 5 comments
Closed

[BUG?] CalibratedClassifierCV is not marked as a meta-estimator #5518

ainafp opened this issue Oct 21, 2015 · 5 comments
Labels
module:calibration

Comments

@ainafp
Copy link

ainafp commented Oct 21, 2015 

from sklearn.utils.testing import all_estimators
estimator_names = zip(*all_estimators(include_meta_estimators=False))[0] 
'CalibratedClassifierCV' in estimator_names
@amueller
Copy link
Member

yeah I think it should be... but then we shouldn't have a default estimator argument, right? or should we?

@agramfort
Copy link
Member

agramfort commented Oct 22, 2015 via email

@ainafp ainafp mentioned this issue Oct 22, 2015
Closed
@amueller
Copy link
Member

I can think of two: "inherits from MetaEstimatorMixin" (which I added basically for the common tests as a tag), and "is not default constructible, but can be constructed with an estimator as first init parameter)". Or maybe it just is "Takes an estimator as an __init__ parameter"?

@agramfort
Copy link
Member

Or maybe it just is "Takes an estimator as an init parameter"?

ok then CalibratedClassifierCV is a meta estimator

@lucyleeow
Copy link
Member

I think this can be closed, we no longer have include_meta_estimators since #8022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module:calibration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@agramfort @amueller @cmarmo @ainafp @lucyleeow