-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
PR tags used in sklearn #6211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
MRG is a tag for a PR title, ENH for a commit. |
@amueller where exactly do you think this should go? |
At the end of the contribution guide. http://scikit-learn.org/dev/developers/contributing.html |
@dsquareindia did you open a PR for this issue? |
i think he was working on #6176 and was planning to put that in there (according to #6211 (comment)), but i got busy with gsoc since i last offered to take it up. i sorta forgot about it, but if this is something we want i could try wrapping it up again |
imo the rebasing part is still quite useful, squashing not as much now that github lets you squash and commit. |
I was thinking of adding a small section in the documentation telling what each tag (eg. MRG, ENH etc.) stands for and when it's used, somewhere over here. Might help beginners in scikit learn and even in other organisations for that matter.
The text was updated successfully, but these errors were encountered: