-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
IsotonicRegression does not pass check_estimator #6554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
there should be a way to tag the estimator with conditions like "does only take 1d input". Currently this is hard-coded for Isotonic in the tests. |
Actually, given that isotonic regression has a natural multidimensional generalization (#5744), perhaps it should be instead changed to take a 2d-input. |
see #6599. |
Briefly, the issue is that IsotonicRegression takes (quite reasonably?) a 1D-array instead of a (n, 1) array as input.
(I ran into that issue while wrapping Tibshirani & Hoefling's near-isotonic regression (R package
neariso
) using rpy2.)The text was updated successfully, but these errors were encountered: