Skip to content

IsotonicRegression does not pass check_estimator #6554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anntzer opened this issue Mar 16, 2016 · 3 comments
Closed

IsotonicRegression does not pass check_estimator #6554

anntzer opened this issue Mar 16, 2016 · 3 comments

Comments

@anntzer
Copy link
Contributor

anntzer commented Mar 16, 2016

Briefly, the issue is that IsotonicRegression takes (quite reasonably?) a 1D-array instead of a (n, 1) array as input.
(I ran into that issue while wrapping Tibshirani & Hoefling's near-isotonic regression (R package neariso) using rpy2.)

@amueller
Copy link
Member

there should be a way to tag the estimator with conditions like "does only take 1d input". Currently this is hard-coded for Isotonic in the tests.
This should be configurable exactly for your use case.
There is currently an estimator_type attribute that does something related (declare classifiers and regressors) but that's not powerful enough. We probably need to add a classifier_tags property or something like that (though how do you set that through inheritance? have it be a property that calls the parent property?)

@anntzer
Copy link
Contributor Author

anntzer commented Mar 16, 2016

Actually, given that isotonic regression has a natural multidimensional generalization (#5744), perhaps it should be instead changed to take a 2d-input.
Still, I agree that a marker "takes only 1D input" could be generally useful (for example I certainly don't plan to write a multidimensional generalization to near-isotonic regression).

@amueller
Copy link
Member

amueller commented Oct 8, 2016

see #6599.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants