Skip to content

naming of parameters in BayesianMixture #7129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amueller opened this issue Aug 2, 2016 · 4 comments
Closed

naming of parameters in BayesianMixture #7129

amueller opened this issue Aug 2, 2016 · 4 comments

Comments

@amueller
Copy link
Member

amueller commented Aug 2, 2016

The parameter names in the BayesianMixture seems weird to me.
The priors are called init. But they are not initialization, they are the priors. They don't change during the model building.
ping @agramfort @tguillemot
@tguillemot
Copy link
Contributor

BayesianMixture is WIP and indeed I have planned to change that before being mergeable.

@agramfort
Copy link
Member

agramfort commented Aug 3, 2016 via email

@tguillemot
Copy link
Contributor

Already done in #6651 :)

@amueller
Copy link
Member Author

amueller commented Aug 3, 2016

Ah, sorry didn't have the right place to comment. Thanks @tguillemot

@amueller amueller closed this as completed Aug 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@agramfort @amueller @tguillemot