Skip to content

check_estimator should allow NaNs? #7737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chkoar opened this issue Oct 24, 2016 · 1 comment
Closed

check_estimator should allow NaNs? #7737

chkoar opened this issue Oct 24, 2016 · 1 comment

Comments

@chkoar
Copy link
Contributor

chkoar commented Oct 24, 2016

In imbalanced-learn we have cases (e.g. scikit-learn-contrib/imbalanced-learn#157) where some samplers like RandomUnderSampler and RandomOverSampler could naturally accept NaNs for X because the values of the X are irrelevant to the random sampling itself. If we modifiy the Random*Samplers to accept NaNs the check_estimator tests fall for them.

So we have two options:

  • Skip the check_estimator tests for the Random*Samplers
  • Do not accept the NaNs at all and document it clearly.

Any workaround on this? What are your thoughts?

This issue in general is related to #6981.

@amueller
Copy link
Member

Good point.
Also see #6715 and #6599.
One more tag to add...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants