From 2c2b6c35e75d505564b7c477b463177b1f1199d9 Mon Sep 17 00:00:00 2001 From: Jake VanderPlas Date: Mon, 16 Jul 2018 07:47:54 -0700 Subject: [PATCH 1/2] BUG: fix KD Tree node construction (fixes #11313) --- sklearn/neighbors/kd_tree.pyx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sklearn/neighbors/kd_tree.pyx b/sklearn/neighbors/kd_tree.pyx index 08d2ff8ef0e3e..4e713f846a5ec 100644 --- a/sklearn/neighbors/kd_tree.pyx +++ b/sklearn/neighbors/kd_tree.pyx @@ -69,6 +69,8 @@ cdef int init_node(BinaryTree tree, ITYPE_t i_node, for j in range(n_features): lower_bounds[j] = fmin(lower_bounds[j], data_row[j]) upper_bounds[j] = fmax(upper_bounds[j], data_row[j]) + + for j in range(n_features): if tree.dist_metric.p == INF: rad = fmax(rad, 0.5 * (upper_bounds[j] - lower_bounds[j])) else: From 976acb3d32e7ea04f02e82cef2033d5442dce6e8 Mon Sep 17 00:00:00 2001 From: Jake VanderPlas Date: Tue, 17 Jul 2018 12:00:24 -0700 Subject: [PATCH 2/2] DOC: add changelog entry for #11556 --- doc/whats_new/v0.20.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/whats_new/v0.20.rst b/doc/whats_new/v0.20.rst index 8ed142b6367ea..617a40113065b 100644 --- a/doc/whats_new/v0.20.rst +++ b/doc/whats_new/v0.20.rst @@ -655,6 +655,9 @@ Neighbors warning when no neighbors are found for samples. :issue:`9655` by :user:`Andreas Bjerre-Nielsen `. +- Fixed a bug in ``KDTree`` construction that results in faster construction + and querying times. :issue:`11556` by :user:`Jake VanderPlas ` + Feature Extraction - Fixed a bug in :func:`feature_extraction.image.extract_patches_2d` which would