Skip to content

MAINT hotfix circle-ci job dependency #12780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2018
Merged

MAINT hotfix circle-ci job dependency #12780

merged 1 commit into from
Dec 14, 2018

Conversation

adrinjalali
Copy link
Member

After changing the circle-ci job names in #12746 I forgot to change the dependency of the deploy step. This fixes that.

@adrinjalali
Copy link
Member Author

@qinhanmin2014 this is why master was having issues with circle-ci.

qinhanmin2014
qinhanmin2014 approved these changes Dec 14, 2018
View reviewed changes
Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see what'll happen.

@qinhanmin2014 qinhanmin2014 merged commit 419c6cc into scikit-learn:master Dec 14, 2018
@adrinjalali adrinjalali deleted the ci/hotfix-circle-ci branch December 14, 2018 13:11
@adrinjalali
Copy link
Member Author

@qinhanmin2014 the deploys seem to be failing with:

+ git push
ERROR: The key you are authenticating with has been marked as read only.
fatal: Could not read from remote repository.

example job

@qinhanmin2014
Copy link
Member

I don't think you should persist generated documentation in min dependency job.
And we also need to update the comment in deploy job: # Attach documentation generated in the 'python3' step
If the problem persists, maybe we need someone more familiar with Circle CI (e.g., lesteve)

amueller pushed a commit to amueller/scikit-learn that referenced this pull request Dec 14, 2018
@adrinjalali @amueller
MNT hotfix circle-ci job dependency (scikit-learn#12780)
101ddb3
adrinjalali added a commit to adrinjalali/scikit-learn that referenced this pull request Jan 7, 2019
@adrinjalali
MNT hotfix circle-ci job dependency (scikit-learn#12780)
befc8c8
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
@adrinjalali
MNT hotfix circle-ci job dependency (scikit-learn#12780)
ba83309
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "MNT hotfix circle-ci job dependency (scikit-learn#12780)"
be23d47 
This reverts commit ba83309.
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "MNT hotfix circle-ci job dependency (scikit-learn#12780)"
b1e36d0 
This reverts commit ba83309.
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@adrinjalali @koenvandevelde
MNT hotfix circle-ci job dependency (scikit-learn#12780)
cbccc7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrinjalali @qinhanmin2014