[MRG] Documentation/svc documentation references #12859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
reviewed
Dec 24, 2018
sklearn/svm/classes.py
Outdated
| @@ -558,15 +558,15 @@ class SVC(BaseSVC): | |||
|
|
|||
| probA_ : array, shape = [n_class * (n_class-1) / 2] | |||
| probB_ : array, shape = [n_class * (n_class-1) / 2] | |||
|
|
|||
sklearn/svm/classes.py
Outdated
| @@ -593,11 +593,15 @@ class SVC(BaseSVC): | |||
| implemented using liblinear. Check the See also section of | |||
| LinearSVC for more comparison element. | |||
|
|
|||
| Notes | |||
|
|
|||
| References | |||
| ----- | |||
There was a problem hiding this comment.
Should be:
References
----------
sklearn/svm/classes.py
Outdated
| @@ -593,11 +593,15 @@ class SVC(BaseSVC): | |||
| implemented using liblinear. Check the See also section of | |||
| LinearSVC for more comparison element. | |||
|
|
|||
| Notes | |||
|
|
|||
sklearn/svm/classes.py
Outdated
| **References:** | ||
| `LIBSVM: A Library for Support Vector Machines | ||
| <http://www.csie.ntu.edu.tw/~cjlin/papers/libsvm.pdf>`__ | ||
| .. [1]`LIBSVM: A Library for Support Vector Machines |
|
@NicolasHug |
NicolasHug
reviewed
Jan 5, 2019
Co-Authored-By: tashay <tashay.g@gmail.com>
jnothman
reviewed
Jan 7, 2019
sklearn/svm/classes.py
Outdated
| @@ -565,8 +565,7 @@ class SVC(BaseSVC): | |||
| ``1 / (1 + exp(decision_value * probA_ + probB_))`` | |||
| where ``probA_`` and ``probB_`` are learned from the dataset. For more | |||
| information on the multiclass case and training procedure see section | |||
| 8 of LIBSVM: A Library for Support Vector Machines (in References) | |||
| for more. | |||
| 8 of LIBSVM: A Library for Support Vector Machines [1]_. | |||
There was a problem hiding this comment.
I think [2]_ should also be cited somewhere. Perhaps under the probability parameter description above.
jnothman
approved these changes
Jan 10, 2019
sklearn/svm/classes.py
Outdated
| for more. | ||
| where ``probA_`` and ``probB_`` are learned from the dataset [2]_. For | ||
| more information on the multiclass case and training procedure see | ||
| section 8 of LIBSVM: A Library for Support Vector Machines [1]_. |
There was a problem hiding this comment.
section 8 of [1]_ should suffice?
jnothman
approved these changes
Jan 13, 2019
|
Thanks @tashay! |
|
yeah! thank you @tashay 👍, as well as @NicolasHug and @jnothman And thanks to @cynco too. |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Feb 19, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit e89aadf.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit e89aadf.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
This PR is a continuation of the work on and resolves #12217.
What does this implement/fix? Explain your changes.
This PR adds references for SVC
Any other comments?
#wimlds
cc: @reshamas