WEB/DOC link to dev docs instead of contributing docs in the menu #12885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amueller
commented
Dec 28, 2018
| @@ -41,7 +41,6 @@ ticket to the | |||
| also welcome to post feature requests or pull requests. | |||
|
|
|||
|
|
|||
| ================== | |||
There was a problem hiding this comment.
This cleans up the TOC of this document somewhat.
qinhanmin2014
approved these changes
Dec 29, 2018
|
I think given that this changes the navigation I would have liked to wait for another +1 and/or wait for others to have time to comment. |
|
Apologies I though this is a minor doc change, will be more careful next time. |
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
Jan 7, 2019
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Feb 19, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pet peeve of mine:
Right now the "Documentation" page links to the developer docs, while the menu links to "developers/contributing". All of the other menu entries correspond to one of the "big tocs" shown on the "Documentation" page: API, User Guide, Tutorial etc. But "Contributing" links into "developers/contributing" making the "developers" docs harder to find, which also means they are in worse shape then the overall docs.
I think we should link to the higher level toc in the menu to be consistent with the "Documentation" page. We might want to reorder the items in the "Developer" toc, though (like putting installation above contributing maybe?). I didn't do that here.