From 34537a305fefe7e4472547514158e365f378ec8f Mon Sep 17 00:00:00 2001 From: Hanmin Qin Date: Thu, 3 Jan 2019 23:24:09 +0800 Subject: [PATCH 1/2] DOC Update note for code contribution --- doc/developers/contributing.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/developers/contributing.rst b/doc/developers/contributing.rst index 3ce7907947f7a..3dbddfa00f865 100644 --- a/doc/developers/contributing.rst +++ b/doc/developers/contributing.rst @@ -169,10 +169,10 @@ Contributing code .. note:: - To avoid duplicating work, it is highly advised that you contact the - developers on the mailing list before starting work on a non-trivial feature. - - https://mail.python.org/mailman/listinfo/scikit-learn + To avoid duplicating work, it is highly advised that you search through the + issue tracker and the PR list. If you want to work on a non-trivial feature, + it's recommended to first open an issue in the issue tracker to get some + feedbacks from core developers. How to contribute ----------------- From 47f46d43eaf90a7a0dc773b1269a1938f662ea13 Mon Sep 17 00:00:00 2001 From: Hanmin Qin Date: Fri, 4 Jan 2019 23:38:20 +0800 Subject: [PATCH 2/2] review comments --- doc/developers/contributing.rst | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/doc/developers/contributing.rst b/doc/developers/contributing.rst index 3dbddfa00f865..80ac2c4d9ff02 100644 --- a/doc/developers/contributing.rst +++ b/doc/developers/contributing.rst @@ -170,9 +170,12 @@ Contributing code .. note:: To avoid duplicating work, it is highly advised that you search through the - issue tracker and the PR list. If you want to work on a non-trivial feature, - it's recommended to first open an issue in the issue tracker to get some - feedbacks from core developers. + `issue tracker `_ and + the `PR list `_. + If in doubt about duplicated work, or if you want to work on a non-trivial + feature, it's recommended to first open an issue in + the `issue tracker `_ + to get some feedbacks from core developers. How to contribute -----------------