BUG: fix deprecation handling in OneHotEncoder for categorical_features + handle_unknown='ignore' case #12923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es + handle_unknown='ignore' case
jnothman
approved these changes
Jan 6, 2019
|
@jnothman I see you labeled the issue as 0.20.3. So we plan to do another bug-fix release? Shall I then add a whatsnew note in a 0.20.3 section? |
|
I labelled it 0.20.3 in case we decide to do another bugfix release. |
|
But so then I put a whatsnew in 0.20.3 section, which we can always move later to 0.21 in case we didn't release that? |
|
I suppose it could work either way around. You're right that creating the
changelog for 0.20.3 might be neater.
|
glemaitre
reviewed
Jan 14, 2019
Co-Authored-By: jorisvandenbossche <jorisvandenbossche@gmail.com>
glemaitre
approved these changes
Jan 14, 2019
|
Thanks @jorisvandenbossche |
|
Is that worth a release? Or wait and see? |
|
This alone is not worth a release IMO, but there are some others tagged with 0.20.3 |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Feb 19, 2019
…handle_unknown='ignore' case (scikit-learn#12923)
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…handle_unknown='ignore' case (scikit-learn#12923)
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…tures + handle_unknown='ignore' case (scikit-learn#12923)" This reverts commit 374f621.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…tures + handle_unknown='ignore' case (scikit-learn#12923)" This reverts commit 374f621.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
…handle_unknown='ignore' case (scikit-learn#12923)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12881