[MRG] Configure lgtm.yml for CPP #13044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FTR, this is the config file we wrote internally and applied to get the C++ analysis working: extraction:
cpp:
prepare:
packages:
- python3-numpy
- python3-scipy
- cython3
after_prepare:
# Build works fine with Ubuntu 18.04's cython version 0.26.1
- sed -i "s/0.28.5/0.26.1/" sklearn/_build_utils/__init__.py
index:
build_command:
- python3 setup.py build |
|
The one you've written though seems to also work, and is a lot cleaner, so this PR LGTM if squashed :) |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Jan 30, 2019
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 7, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 1cc6736.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 1cc6736.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LGTM by using python 3 to build scikit-learn when going through C/C++ extraction.