Skip to content

ENH: Preserve float32/64 for SGD #13346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

ENH: Preserve float32/64 for SGD #13346

wants to merge 5 commits into from

Conversation

massich
Copy link
Contributor

@massich massich commented Mar 1, 2019

Works on #11000
close #9084 (takes over)

@massich
Copy link
Contributor Author

massich commented Mar 1, 2019

This PR touches WeightVector which has a double attribute that needs to be fused. (which is not possible).

I'll submit a PR templating WeightVector

@massich massich mentioned this pull request Mar 1, 2019
Closed
@glemaitre glemaitre mentioned this pull request Mar 4, 2019
Open
28 tasks
Base automatically changed from master to main January 22, 2021 10:50
@mbatoul mbatoul mentioned this pull request Jul 7, 2021
Merged
@jeremiedbb
Copy link
Member

Done in #25587

@jeremiedbb jeremiedbb closed this Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cython help wanted module:linear_model Needs work Stalled
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@massich @jeremiedbb @amueller @cmarmo @thomasjpfan