Skip to content

fix note range in contributing.html #13722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kevin1kevin1k
Copy link

@kevin1kevin1k kevin1kevin1k commented Apr 25, 2019

Reference Issues/PRs

Fixes #13721

What does this implement/fix? Explain your changes.

Fix the range of the note

Any other comments?

@NicolasHug
Copy link
Member

It doesn't seem to be fixed looking at the generated docs https://56141-843222-gh.circle-artifacts.com/0/doc/developers/contributing.html

@kevin1kevin1k
Copy link
Author

Sorry I didn't check it.
Is there any good way to fix it, or is it fine to put the note after point 7? (some changes may need to be made)
Thanks!

@NicolasHug
Copy link
Member

There are 2 things going on:

  1. The note should be inside the 5. bullet point. Something like that:
5. Create a branch.....
   ...
   Note::
      Blahblahblah....

  1. This whole section is indented with one space. The space should be removed.

@kevin1kevin1k
Copy link
Author

Thanks for the kind help!
I've added a new commit and hope it will work this time.

@NicolasHug
Copy link
Member

Worked like a charm, thanks!

Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kevin1kevin1k

@qinhanmin2014 qinhanmin2014 merged commit 519bedc into scikit-learn:master May 5, 2019
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request May 6, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Range of note on contributing.html
3 participants