CI/DOC Use sphinx-gallery 0.3.1 #14833
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fine with merging to the branch... Bug fix releases are cherry-picked
into a branch and then merged without squash in order to avoid having the
docs inconsistent with the released code, while maintaining individuated
commits.
|
sphinx 1.6.2 is only available in free channel (which was removed). [doc build]
|
I compared the examples gallery from the stable doc and the examples gallery from the doc generated from this PR and I did not spot any difference. I also looked at a few examples and they were identical. It seems like I will have to fix a few things related to conda removing the |
|
Closing this one, waiting for the next scikit-learn relase for the Binder links to appear in the stable doc seems a better idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR target the
0.21.Xbranch. I cherry-picked the commit from #14507 (merged 4 weeks ago in master).My goal behind this is to add binder links to the stable doc (very similar to #11221 which added binder links to the dev doc). The work done in master needs sphinx-gallery 0.3.1.
I am not expecting any issues, but once the doc is built in this PR I will double-check whether I don't see any obvious problems in the generated doc.
Also what is the preferred way of changing things in a relase branch:
0.21.Xbranch (more obvious that it is a cherry-pick of a commit in master)? This seems to be the approach for bug-fixes in0.21.Xas far as I can see.