Skip to content

DOC change model evaluation section title #15157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2019
Merged

DOC change model evaluation section title #15157

merged 2 commits into from
Oct 14, 2019

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Oct 8, 2019 •
edited
Loading

This PR changes the section title

Model evaluation: quantifying the quality of predictions

to

Metrics and scoring: quantifying the quality of predictions

Reasons:

  • This section is about metrics and scorers
  • Model evaluation is actually covered before in the "Cross-validation: evaluating estimator performance" section.

amueller
amueller reviewed Oct 8, 2019
View reviewed changes
@NicolasHug NicolasHug changed the title [MRG] DOC change model selection section title [MRG] DOC change model evaluation section title Oct 8, 2019
thomasjpfan
thomasjpfan reviewed Oct 8, 2019
View reviewed changes
doc/modules/model_evaluation.rst
@@ -2,9 +2,9 @@

.. _model_evaluation:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the ref as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we could but this will break existing URLs

jnothman
jnothman reviewed Oct 9, 2019
View reviewed changes
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, except for the ambiguity with pairwise metrics

@NicolasHug
Copy link
Member Author

I don't really find it ambiguous FWIW

@NicolasHug
Copy link
Member Author

If I don't get additional comments within a few days I'll merge this

rth
rth approved these changes Oct 14, 2019
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think it's an improvement.

Given that that page has words scor(e|ing|.*) repeated ~326 times, I think it's fine to also have it in the title.

@rth rth changed the title [MRG] DOC change model evaluation section title DOC change model evaluation section title Oct 14, 2019
@rth rth merged commit 3c13450 into scikit-learn:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman left review comments

@amueller amueller amueller approved these changes

@rth rth rth approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NicolasHug @jnothman @amueller @rth @thomasjpfan