MAINT revert unecessary deprecation for permutation_importance module #15354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
approved these changes
Oct 24, 2019
|
It does see #14028
…On Thu, 24 Oct 2019 at 15:19, Nicolas Hug ***@***.***> wrote:
***@***.**** approved this pull request.
OK, no idea whether this will fix the other pytest issue but indeed we
don't need to create the fake file in this case
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#15354?email_source=notifications&email_token=ABY32PZ3HAFSCQKRJ5X6OK3QQGOHPA5CNFSM4JETJBD2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJC5E6A#pullrequestreview-306565752>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABY32P2LORSPYMYZFOYLPFDQQGOHPANCNFSM4JETJBDQ>
.
--
Guillaume Lemaitre
Scikit-learn @ Inria Foundation
https://glemaitre.github.io/
|
rth
approved these changes
Oct 24, 2019
ogrisel
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #14028, we face a
pytestbug which confusingpermutation_importanceas a module and a function after the collection of the tests.permutation_importance.pyhas been renamed to_permutation_importance.pyduring the module privatization. However, we are raising a deprecation warning and creating apermutation_importance.pymodule for that. This is unnecessary sincepermutation_importance.pymodule is not existing in scikit-learn 0.21 and his only present in the master branch. Therefore, we can safely rename the module with the leading underscore without breaking people code and work around thepytestbug.Note that it would be nice to get a minimal example to report to pytest regarding this issue.