[MRG] DOC add versionadded directive to some estimators #15849

reshamas · 2019-12-09T16:35:36Z

Reference Issues/PRs

Label docstrings with versionadded #15426

What does this implement/fix? Explain your changes.

Closes #15494

Any other comments?

continuing work by @harini-sridhar for SF #wimlds sprint (Nov 2019)

…n, PLSSVD, PatchExtractor, Pipeline, PowerTransformer, PredefinedSplit (Issue #15426)

reshamas · 2019-12-09T20:38:41Z

Do we know what these errors are? I don't believe they are related to any of the files that were updated:

(sklearndev) ➜  scikit-learn git:(docs_version_added) pytest sklearn
============================================ test session starts =============================================
platform darwin -- Python 3.6.9, pytest-5.0.1, py-1.8.0, pluggy-0.13.1
rootdir: /Users/reshamashaikh/scikit-learn, inifile: setup.cfg
collected 8266 items / 2 errors / 2 skipped / 8262 selected                                                  

=================================================== ERRORS ===================================================
_______________________________ ERROR collecting sklearn/tests/test_common.py ________________________________
sklearn/tests/test_common.py:52: in <module>
    all_estimators()
sklearn/utils/__init__.py:1197: in all_estimators
    module = __import__(modname, fromlist="dummy")
sklearn/cluster/affinity_propagation_.py:5: in <module>
    from ..externals._pep562 import Pep562
E   ModuleNotFoundError: No module named 'sklearn.externals._pep562'
_______________________________ ERROR collecting sklearn/tests/test_common.py ________________________________
ImportError while importing test module '/Users/reshamashaikh/scikit-learn/sklearn/tests/test_common.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
sklearn/tests/test_common.py:52: in <module>
    all_estimators()
sklearn/utils/__init__.py:1197: in all_estimators
    module = __import__(modname, fromlist="dummy")
sklearn/cluster/affinity_propagation_.py:5: in <module>
    from ..externals._pep562 import Pep562
E   ModuleNotFoundError: No module named 'sklearn.externals._pep562'
========================================== short test summary info ===========================================
SKIPPED [2] /Users/reshamashaikh/scikit-learn/sklearn/ensemble/_hist_gradient_boosting/tests/test_compare_lightgbm.py:17: could not import 'lightgbm': No module named 'lightgbm'
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 2 errors during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
============================== 2 skipped, 2 warnings, 2 error in 15.78 seconds ===============================

glemaitre · 2019-12-10T13:41:28Z

Make sure to merge master into your branch. It seems that you have a missing file.
It was introduced in this PR: #15431

…into docs_version_added

reshamas · 2019-12-10T16:08:41Z

@glemaitre Thanks. I have new error below. Do the instructions related to environment set up for the sprint need to be updated? Or is this a temporary problem?

The instructions here (developers' version) do not match what is listed in Andy's instructions

================================================== FAILURES ==================================================
______________________________________ test_openmp_parallelism_enabled _______________________________________

    def test_openmp_parallelism_enabled():
        # Check that sklearn is built with OpenMP-based parallelism enabled.
        # This test can be skipped by setting the environment variable
        # ``SKLEARN_SKIP_OPENMP_TEST``.
        if os.getenv("SKLEARN_SKIP_OPENMP_TEST"):
            pytest.skip("test explicitly skipped (SKLEARN_SKIP_OPENMP_TEST)")
    
        base_url = "dev" if __version__.endswith(".dev0") else "stable"
        err_msg = textwrap.dedent(
            """
            This test fails because scikit-learn has been built without OpenMP.
            This is not recommended since some estimators will run in sequential
            mode instead of leveraging thread-based parallelism.
    
            You can find instructions to build scikit-learn with OpenMP at this
            address:
    
                https://scikit-learn.org/{}/developers/advanced_installation.html
    
            You can skip this test by setting the environment variable
            SKLEARN_SKIP_OPENMP_TEST to any value.
            """).format(base_url)
    
>       assert _openmp_parallelism_enabled(), err_msg
E       AssertionError: 
E         This test fails because scikit-learn has been built without OpenMP.
E         This is not recommended since some estimators will run in sequential
E         mode instead of leveraging thread-based parallelism.
E         
E         You can find instructions to build scikit-learn with OpenMP at this
E         address:
E         
E             https://scikit-learn.org/dev/developers/advanced_installation.html
E         
E         You can skip this test by setting the environment variable
E         SKLEARN_SKIP_OPENMP_TEST to any value.
E         
E       assert False
E        +  where False = _openmp_parallelism_enabled()

sklearn/tests/test_build.py:32: AssertionError

glemaitre · 2019-12-10T16:23:45Z

We might have updated the guideline on the website since the last sprint.

The new error is explicit. Basically, you should have MacOS and you build without openmp support by setting the environment variable SKLEARN_SKIP_OPENMP_TEST at that time. I assume that you might have set the variable permanently and therefore we have a test failing telling you about it.

So if you want the thing to work locally, either set SKLEARN_SKIP_OPENMP_TEST such that the test will be skipped (e.g. you can export in your .bashrc). Otherwise, it is a bit more complexed but you can rebuild scikit-learn with openmp support meaning that you will need to install llvm including openmp. In this case, you need to follow the install guideline online, especially this section: https://scikit-learn.org/dev/developers/advanced_installation.html#compiler-macos

If you are using conda>=4.7, I think this is pretty straightforward to install with openmp support.

Be aware that the tests which are failing here are due to a falsely docstring.

glemaitre

A couple issues which could probably solve the doc build.

glemaitre · 2019-12-10T16:47:14Z

sklearn/cross_decomposition/_pls.py

@@ -647,6 +649,7 @@ class PLSRegression(_PLS):
    In french but still a reference:
    Tenenhaus, M. (1998). La regression PLS: theorie et pratique. Paris:
    Editions Technic.
+


could you remove this line (it does not follow the guide from numpydoc)

but remove this one :)

You need to remove this line

glemaitre · 2019-12-10T16:47:53Z

sklearn/cross_decomposition/_pls.py

@@ -791,6 +794,8 @@ class PLSCanonical(_PLS):
    --------
    CCA
    PLSSVD
+
+    .. versionadded:: 0.8


it should be placed on the top above parameters

glemaitre · 2019-12-10T16:48:12Z

sklearn/cross_decomposition/_pls.py

@@ -858,6 +863,8 @@ class PLSSVD(TransformerMixin, BaseEstimator):
    --------
    PLSCanonical
    CCA
+
+    .. versionadded:: 0.8


above Parameters sections`

sklearn/feature_extraction/image.py

glemaitre · 2019-12-10T16:49:02Z

sklearn/feature_extraction/image.py

@@ -513,6 +514,7 @@ class PatchExtractor(BaseEstimator):
    >>> pe_trans = pe.transform(X)
    >>> print('Patches shape: {}'.format(pe_trans.shape))
    Patches shape: (545706, 2, 2)
+


remove this line

sklearn/model_selection/_split.py

glemaitre · 2019-12-10T16:49:16Z

sklearn/model_selection/_split.py

@@ -1842,6 +1843,7 @@ class PredefinedSplit(BaseCrossValidator):
    ...     y_train, y_test = y[train_index], y[test_index]
    TRAIN: [1 2 3] TEST: [0]
    TRAIN: [0 2] TEST: [1 3]
+


remove this line

sklearn/pipeline.py

glemaitre · 2019-12-10T16:49:31Z

sklearn/pipeline.py

@@ -122,6 +123,7 @@ class Pipeline(_BaseComposition):
    (1, 10)
    >>> sub_pipeline.inverse_transform(coef).shape
    (1, 20)
+


remove this line

still, this line to be removed

glemaitre · 2019-12-10T16:49:46Z

sklearn/preprocessing/_data.py

@@ -2739,6 +2741,7 @@ class PowerTransformer(TransformerMixin, BaseEstimator):

    .. [2] G.E.P. Box and D.R. Cox, "An Analysis of Transformations", Journal
           of the Royal Statistical Society B, 26, 211-252 (1964).
+


remove this line

…into docs_version_added

glemaitre

Otherwise LGTM

glemaitre · 2019-12-10T18:13:27Z

sklearn/cross_decomposition/_pls.py

@@ -643,10 +645,10 @@ class PLSRegression(_PLS):
    Jacob A. Wegelin. A survey of Partial Least Squares (PLS) methods, with
    emphasis on the two-block case. Technical Report 371, Department of
    Statistics, University of Washington, Seattle, 2000.
-


You should let this blank line :)

You should keep this blank line

glemaitre · 2019-12-10T18:13:34Z

sklearn/cross_decomposition/_pls.py

@@ -647,6 +649,7 @@ class PLSRegression(_PLS):
    In french but still a reference:
    Tenenhaus, M. (1998). La regression PLS: theorie et pratique. Paris:
    Editions Technic.
+


but remove this one :)

glemaitre · 2019-12-10T18:13:59Z

sklearn/cross_decomposition/_pls.py

@@ -858,6 +865,7 @@ class PLSSVD(TransformerMixin, BaseEstimator):
    --------
    PLSCanonical
    CCA
+


remove this line

glemaitre · 2019-12-10T18:14:11Z

sklearn/cross_decomposition/_pls.py

@@ -791,6 +795,7 @@ class PLSCanonical(_PLS):
    --------
    CCA
    PLSSVD
+


remove this line

Remove this line

glemaitre · 2019-12-10T18:14:36Z

sklearn/pipeline.py

@@ -122,6 +123,7 @@ class Pipeline(_BaseComposition):
    (1, 10)
    >>> sub_pipeline.inverse_transform(coef).shape
    (1, 20)
+


still, this line to be removed

…into docs_version_added

reshamas · 2019-12-10T21:20:16Z

@glemaitre I believe I have made all the requested changes. At least, no errors from last PR.

glemaitre

I think that you edited the wrong place for some of the blank line. I commented on the specific line.

glemaitre · 2019-12-10T22:04:55Z

sklearn/cross_decomposition/_pls.py

@@ -234,11 +234,9 @@ class _PLS(TransformerMixin, RegressorMixin, MultiOutputMixin, BaseEstimator,
    Jacob A. Wegelin. A survey of Partial Least Squares (PLS) methods, with
    emphasis on the two-block case. Technical Report 371, Department of
    Statistics, University of Washington, Seattle, 2000.
-


You need to keep this blank line

glemaitre · 2019-12-10T22:05:09Z

sklearn/cross_decomposition/_pls.py

    In French but still a reference:
    Tenenhaus, M. (1998). La regression PLS: theorie et pratique. Paris:
    Editions Technic.
-


you need to keep this blank line

glemaitre · 2019-12-10T22:05:31Z

sklearn/cross_decomposition/_pls.py

@@ -643,10 +645,10 @@ class PLSRegression(_PLS):
    Jacob A. Wegelin. A survey of Partial Least Squares (PLS) methods, with
    emphasis on the two-block case. Technical Report 371, Department of
    Statistics, University of Washington, Seattle, 2000.
-


You should keep this blank line

glemaitre · 2019-12-10T22:05:38Z

sklearn/cross_decomposition/_pls.py

@@ -647,6 +649,7 @@ class PLSRegression(_PLS):
    In french but still a reference:
    Tenenhaus, M. (1998). La regression PLS: theorie et pratique. Paris:
    Editions Technic.
+


You need to remove this line

glemaitre · 2019-12-10T22:05:45Z

sklearn/cross_decomposition/_pls.py

@@ -791,6 +795,7 @@ class PLSCanonical(_PLS):
    --------
    CCA
    PLSSVD
+


Remove this line

glemaitre · 2019-12-10T22:05:51Z

sklearn/cross_decomposition/_pls.py

@@ -858,6 +865,7 @@ class PLSSVD(TransformerMixin, BaseEstimator):
    --------
    PLSCanonical
    CCA
+


remove this line

…into docs_version_added

reshamas · 2019-12-11T14:14:54Z

@cmarmo fyi: to put on your radar.
I took over this PR as it was stalled. It's from the SF Nov 2019 sprint.

…into docs_version_added

glemaitre · 2019-12-19T13:06:50Z

Perfect. Let's merge. Thanks @reshamas

@nkish

* DOC fixed default values in dbscan (#15753) * DOC fix incorrect branch reference in contributing doc (#15779) * DOC relabel Feature -> Efficiency in change log (#15770) * DOC fixed Birch default value (#15780) * STY Minior change on code padding in website theme (#15768) * DOC Fix yticklabels order in permutation importances example (#15799) * Fix yticklabels order in permutation importances example * STY Update wrapper width (#15793) * DOC Long sentence was hard to parse and ambiguous in _classification.py (#15769) * DOC Removed duplicate 'classes_' attribute in Naive Bayes classifiers (#15811) * BUG Fixes pandas dataframe bug with boolean dtypes (#15797) * BUG Returns only public estimators in all_estimators (#15380) * DOC improve doc for multiclass and types_of_target (#15333) * TST Increases tol for check_pca_float_dtype_preservation assertion (#15775) * update _alpha_grid class in _coordinate_descent.py (#15835) * FIX Explicit conversion of ndarray to object dtype. (#15832) * BLD Parallelize sphinx builds on circle ci (#15745) * DOC correct url for preprocessing (#15853) * MNT avoid generating too many cross links in examples (#15844) * DOC Correct wrong doc in precision_recall_fscore_support (#15833) * DOC add comment in check_pca_float_dtype_preservation (#15819) Documenting the changes in #15775 * DOC correct indents in docstring _split.py (#15843) * DOC fix docstring of KMeans based on sklearn guideline (#15754) * DOC fix docstring of AgglomerativeClustering based on sklearn guideline (#15764) * DOC fix docstring of AffinityPropagation based on sklearn guideline (#15777) * DOC fixed SpectralCoclustering and SpectralBiclustering docstrings following sklearn guideline (#15778) * DOC fix FeatureAgglomeration and MiniBatchKMeans docstring following sklearn guideline (#15809) * TST Specify random_state in test_cv_iterable_wrapper (#15829) * DOC Include LinearSV{C, R} in models that support sample_weights (#15871) * DOC correct some indents (#15875) * DOC Fix documentation of default values in tree classes (#15870) * DOC fix typo in docstring (#15887) * DOC FIX default value for xticks_rotation in plot_confusion_matrix (#15890) * Fix imports in pip3 ubuntu by suffixing affected files (#15891) * MNT Raise erorr when normalize is invalid in confusion_matrix (#15888) * [MRG] DOC Increases search results for API object results (#15574) * MNT Ignores warning in pyamg for deprecated scipy.random (#15914) * DOC Instructions to troubleshoot Windows path length limit (#15916) * DOC add versionadded directive to some estimators (#15849) * DOC clarify doc-string of roc_auc_score and add references (#15293) * MNT Adds skip lint to azure pipeline CI (#15904) * BLD Fixes bug when building with NO_MATHJAX=1 (#15892) * [MRG] BUG Checks to number of axes in passed in ax more generically (#15760) * EXA Minor fixes in plot_sparse_logistic_regression_20newsgroups.py (#15925) * BUG Do not shadow public functions with deprecated modules (#15846) * Import sklearn._distributor_init first (#15929) * DOC Fix typos, via a Levenshtein-style corrector (#15923) * DOC in canned comment, mention that PR title becomes commit me… (#15935) * DOC/EXA Correct spelling of "Classification" (#15938) * BUG fix pip3 ubuntu update by suffixing file (#15928) * [MRG] Ways to compute center_shift_total were different in "full" and "elkan" algorithms. (#15930) * TST Fixes integer test for train and test indices (#15941) * BUG ensure that parallel/sequential give the same permutation importances (#15933) * Formatting fixes in changelog (#15944) * MRG FIX: order of values of self.quantiles_ in QuantileTransformer (#15751) * [MRG] BUG Fixes constrast in plot_confusion_matrix (#15936) * BUG use zero_division argument in classification_report (#15879) * DOC change logreg solver in plot_logistic_path (#15927) * DOC fix whats new ordering (#15961) * COSMIT use np.iinfo to define the max int32 (#15960) * DOC Apply numpydoc validation to VotingRegressor methods (#15969) Co-authored-by: Tiffany R. Williams <Tiffany8@users.noreply.github.com> * DOC improve naive_bayes.py documentation (#15943) Co-authored-by: Jigna Panchal <40188288+jigna-panchal@users.noreply.github.com> * DOC Fix default values in Perceptron documentation (#15965) * DOC Improve default values in logistic documentation (#15966) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * DOC Improve documentation of default values for imputers (#15964) * EXA/MAINT Simplify code in manifold learning example (#15949) * DOC Improve default values in SGD documentation (#15967) * DOC Improve defaults in neural network documentation (#15968) * FIX use safe_sparse_dot for callable kernel in LabelSpreading (#15868) * BUG Adds attributes back to check_is_fitted (#15947) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> * DOC update check_is_fitted what's new * DOC change python-devel to python3-devel for yum. (#15986) * DOC Correct the default value of values_format in plot_confusion_matrix (#15981) * [MRG] MNT Updates pypy to use 7.2.0 (#15954) * FIX Add missing 'values_format' param to disp.plot() in plot_confusion_matrix (#15937) * FIX support scalar values in fit_params in SearchCV (#15863) * support a scalar fit param * pep8 * TST add test for desired behavior * FIX introduce _check_fit_params to validate parameters * DOC update whats new * TST tests both grid-search and randomize-search * PEP8 * DOC revert unecessary change * TST add test for _check_fit_params * olivier comments * TST fixes * DOC whats new * DOC whats new * TST revert type of error * add olivier suggestions * address olivier comments * address thomas comments * PEP8 * comments olivier * TST fix test by passing X * avoid to call twice tocsr * add case column/row sparse in check_fit_param * provide optional indices * TST check content when indexing params * PEP8 * TST update tests to check identity * stupid fix * use a distribution in RandomizedSearchCV * MNT add lightgbm to one of the CI build * move to another build * do not install dependencies lightgbm * MNT comments on the CI setup * address some comments * Test fit_params compat without dependency on lightgbm Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> * Remove abstractmethod that silently brake downstream packages (#15996) * FIX restore BaseNB._check_X without abstractmethod decoration (#15997) * Update v0.22 changelog for 0.22.1 (#16002) - set the date - move entry for quantile transformer to the 0.22.1 section - fix alphabetical ordering of modules * STY Removes hidden scroll bar (#15999) * Flake8 fixes * Fix: remove left-over lines that should have been deleted during conflict resolution when rebasing * Fix missing imports * Update version * Fix test_check_is_fitted * Make test_sag_regressor_computed_correctly deterministic (#16003) Fix #15818. Co-authored-by: cgsavard <claire.savard@colorado.edu> Co-authored-by: Joel Nothman <joel.nothman@gmail.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com> Co-authored-by: Matt Hall <matt@agilegeoscience.com> Co-authored-by: Kathryn Poole <kathryn.poole2@gmail.com> Co-authored-by: lucyleeow <jliu176@gmail.com> Co-authored-by: JJmistry <jayminm22@gmail.com> Co-authored-by: Juan Carlos Alfaro Jiménez <JuanCarlos.Alfaro@uclm.es> Co-authored-by: SylvainLan <sylvain.s.lannuzel@gmail.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Hanmin Qin <qinhanmin2005@sina.com> Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Vachan D A <vachanda@users.noreply.github.com> Co-authored-by: Sambhav Kothari <sambhavs.email@gmail.com> Co-authored-by: wenliwyan <12013376+wenliwyan@users.noreply.github.com> Co-authored-by: shivamgargsya <shivam.gargshya@gmail.com> Co-authored-by: Reshama Shaikh <rs2715@stern.nyu.edu> Co-authored-by: Oliver Urs Lenz <oulenz@users.noreply.github.com> Co-authored-by: Loïc Estève <loic.esteve@ymail.com> Co-authored-by: Brian Wignall <BrianWignall@gmail.com> Co-authored-by: Ritchie Ng <ritchieng@u.nus.edu> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: inderjeet <43402782+inder128@users.noreply.github.com> Co-authored-by: scibol <scibol@users.noreply.github.com> Co-authored-by: Tirth Patel <tirthasheshpatel@gmail.com> Co-authored-by: Bibhash Chandra Mitra <bibhashm220896@gmail.com> Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org> Co-authored-by: Tiffany R. Williams <Tiffany8@users.noreply.github.com> Co-authored-by: Jigna Panchal <40188288+jigna-panchal@users.noreply.github.com> Co-authored-by: @nkish <19225359+ankishb@users.noreply.github.com> Co-authored-by: Pulkit Mehta <pulkit_mehta_work@yahoo.com> Co-authored-by: David Breuer <DavidBreuer@users.noreply.github.com> Co-authored-by: Niklas <niklas.sm+github@gmail.com> Co-authored-by: Windber <guolipengyeah@126.com> Co-authored-by: Stephen Blystone <29995339+blynotes@users.noreply.github.com> Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>

@nkish

* DOC fixed default values in dbscan (scikit-learn#15753) * DOC fix incorrect branch reference in contributing doc (scikit-learn#15779) * DOC relabel Feature -> Efficiency in change log (scikit-learn#15770) * DOC fixed Birch default value (scikit-learn#15780) * STY Minior change on code padding in website theme (scikit-learn#15768) * DOC Fix yticklabels order in permutation importances example (scikit-learn#15799) * Fix yticklabels order in permutation importances example * STY Update wrapper width (scikit-learn#15793) * DOC Long sentence was hard to parse and ambiguous in _classification.py (scikit-learn#15769) * DOC Removed duplicate 'classes_' attribute in Naive Bayes classifiers (scikit-learn#15811) * BUG Fixes pandas dataframe bug with boolean dtypes (scikit-learn#15797) * BUG Returns only public estimators in all_estimators (scikit-learn#15380) * DOC improve doc for multiclass and types_of_target (scikit-learn#15333) * TST Increases tol for check_pca_float_dtype_preservation assertion (scikit-learn#15775) * update _alpha_grid class in _coordinate_descent.py (scikit-learn#15835) * FIX Explicit conversion of ndarray to object dtype. (scikit-learn#15832) * BLD Parallelize sphinx builds on circle ci (scikit-learn#15745) * DOC correct url for preprocessing (scikit-learn#15853) * MNT avoid generating too many cross links in examples (scikit-learn#15844) * DOC Correct wrong doc in precision_recall_fscore_support (scikit-learn#15833) * DOC add comment in check_pca_float_dtype_preservation (scikit-learn#15819) Documenting the changes in scikit-learn#15775 * DOC correct indents in docstring _split.py (scikit-learn#15843) * DOC fix docstring of KMeans based on sklearn guideline (scikit-learn#15754) * DOC fix docstring of AgglomerativeClustering based on sklearn guideline (scikit-learn#15764) * DOC fix docstring of AffinityPropagation based on sklearn guideline (scikit-learn#15777) * DOC fixed SpectralCoclustering and SpectralBiclustering docstrings following sklearn guideline (scikit-learn#15778) * DOC fix FeatureAgglomeration and MiniBatchKMeans docstring following sklearn guideline (scikit-learn#15809) * TST Specify random_state in test_cv_iterable_wrapper (scikit-learn#15829) * DOC Include LinearSV{C, R} in models that support sample_weights (scikit-learn#15871) * DOC correct some indents (scikit-learn#15875) * DOC Fix documentation of default values in tree classes (scikit-learn#15870) * DOC fix typo in docstring (scikit-learn#15887) * DOC FIX default value for xticks_rotation in plot_confusion_matrix (scikit-learn#15890) * Fix imports in pip3 ubuntu by suffixing affected files (scikit-learn#15891) * MNT Raise erorr when normalize is invalid in confusion_matrix (scikit-learn#15888) * [MRG] DOC Increases search results for API object results (scikit-learn#15574) * MNT Ignores warning in pyamg for deprecated scipy.random (scikit-learn#15914) * DOC Instructions to troubleshoot Windows path length limit (scikit-learn#15916) * DOC add versionadded directive to some estimators (scikit-learn#15849) * DOC clarify doc-string of roc_auc_score and add references (scikit-learn#15293) * MNT Adds skip lint to azure pipeline CI (scikit-learn#15904) * BLD Fixes bug when building with NO_MATHJAX=1 (scikit-learn#15892) * [MRG] BUG Checks to number of axes in passed in ax more generically (scikit-learn#15760) * EXA Minor fixes in plot_sparse_logistic_regression_20newsgroups.py (scikit-learn#15925) * BUG Do not shadow public functions with deprecated modules (scikit-learn#15846) * Import sklearn._distributor_init first (scikit-learn#15929) * DOC Fix typos, via a Levenshtein-style corrector (scikit-learn#15923) * DOC in canned comment, mention that PR title becomes commit me… (scikit-learn#15935) * DOC/EXA Correct spelling of "Classification" (scikit-learn#15938) * BUG fix pip3 ubuntu update by suffixing file (scikit-learn#15928) * [MRG] Ways to compute center_shift_total were different in "full" and "elkan" algorithms. (scikit-learn#15930) * TST Fixes integer test for train and test indices (scikit-learn#15941) * BUG ensure that parallel/sequential give the same permutation importances (scikit-learn#15933) * Formatting fixes in changelog (scikit-learn#15944) * MRG FIX: order of values of self.quantiles_ in QuantileTransformer (scikit-learn#15751) * [MRG] BUG Fixes constrast in plot_confusion_matrix (scikit-learn#15936) * BUG use zero_division argument in classification_report (scikit-learn#15879) * DOC change logreg solver in plot_logistic_path (scikit-learn#15927) * DOC fix whats new ordering (scikit-learn#15961) * COSMIT use np.iinfo to define the max int32 (scikit-learn#15960) * DOC Apply numpydoc validation to VotingRegressor methods (scikit-learn#15969) Co-authored-by: Tiffany R. Williams <Tiffany8@users.noreply.github.com> * DOC improve naive_bayes.py documentation (scikit-learn#15943) Co-authored-by: Jigna Panchal <40188288+jigna-panchal@users.noreply.github.com> * DOC Fix default values in Perceptron documentation (scikit-learn#15965) * DOC Improve default values in logistic documentation (scikit-learn#15966) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> * DOC Improve documentation of default values for imputers (scikit-learn#15964) * EXA/MAINT Simplify code in manifold learning example (scikit-learn#15949) * DOC Improve default values in SGD documentation (scikit-learn#15967) * DOC Improve defaults in neural network documentation (scikit-learn#15968) * FIX use safe_sparse_dot for callable kernel in LabelSpreading (scikit-learn#15868) * BUG Adds attributes back to check_is_fitted (scikit-learn#15947) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> * DOC update check_is_fitted what's new * DOC change python-devel to python3-devel for yum. (scikit-learn#15986) * DOC Correct the default value of values_format in plot_confusion_matrix (scikit-learn#15981) * [MRG] MNT Updates pypy to use 7.2.0 (scikit-learn#15954) * FIX Add missing 'values_format' param to disp.plot() in plot_confusion_matrix (scikit-learn#15937) * FIX support scalar values in fit_params in SearchCV (scikit-learn#15863) * support a scalar fit param * pep8 * TST add test for desired behavior * FIX introduce _check_fit_params to validate parameters * DOC update whats new * TST tests both grid-search and randomize-search * PEP8 * DOC revert unecessary change * TST add test for _check_fit_params * olivier comments * TST fixes * DOC whats new * DOC whats new * TST revert type of error * add olivier suggestions * address olivier comments * address thomas comments * PEP8 * comments olivier * TST fix test by passing X * avoid to call twice tocsr * add case column/row sparse in check_fit_param * provide optional indices * TST check content when indexing params * PEP8 * TST update tests to check identity * stupid fix * use a distribution in RandomizedSearchCV * MNT add lightgbm to one of the CI build * move to another build * do not install dependencies lightgbm * MNT comments on the CI setup * address some comments * Test fit_params compat without dependency on lightgbm Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> * Remove abstractmethod that silently brake downstream packages (scikit-learn#15996) * FIX restore BaseNB._check_X without abstractmethod decoration (scikit-learn#15997) * Update v0.22 changelog for 0.22.1 (scikit-learn#16002) - set the date - move entry for quantile transformer to the 0.22.1 section - fix alphabetical ordering of modules * STY Removes hidden scroll bar (scikit-learn#15999) * Flake8 fixes * Fix: remove left-over lines that should have been deleted during conflict resolution when rebasing * Fix missing imports * Update version * Fix test_check_is_fitted * Make test_sag_regressor_computed_correctly deterministic (scikit-learn#16003) Fix scikit-learn#15818. Co-authored-by: cgsavard <claire.savard@colorado.edu> Co-authored-by: Joel Nothman <joel.nothman@gmail.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com> Co-authored-by: Matt Hall <matt@agilegeoscience.com> Co-authored-by: Kathryn Poole <kathryn.poole2@gmail.com> Co-authored-by: lucyleeow <jliu176@gmail.com> Co-authored-by: JJmistry <jayminm22@gmail.com> Co-authored-by: Juan Carlos Alfaro Jiménez <JuanCarlos.Alfaro@uclm.es> Co-authored-by: SylvainLan <sylvain.s.lannuzel@gmail.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Hanmin Qin <qinhanmin2005@sina.com> Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Vachan D A <vachanda@users.noreply.github.com> Co-authored-by: Sambhav Kothari <sambhavs.email@gmail.com> Co-authored-by: wenliwyan <12013376+wenliwyan@users.noreply.github.com> Co-authored-by: shivamgargsya <shivam.gargshya@gmail.com> Co-authored-by: Reshama Shaikh <rs2715@stern.nyu.edu> Co-authored-by: Oliver Urs Lenz <oulenz@users.noreply.github.com> Co-authored-by: Loïc Estève <loic.esteve@ymail.com> Co-authored-by: Brian Wignall <BrianWignall@gmail.com> Co-authored-by: Ritchie Ng <ritchieng@u.nus.edu> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: inderjeet <43402782+inder128@users.noreply.github.com> Co-authored-by: scibol <scibol@users.noreply.github.com> Co-authored-by: Tirth Patel <tirthasheshpatel@gmail.com> Co-authored-by: Bibhash Chandra Mitra <bibhashm220896@gmail.com> Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org> Co-authored-by: Tiffany R. Williams <Tiffany8@users.noreply.github.com> Co-authored-by: Jigna Panchal <40188288+jigna-panchal@users.noreply.github.com> Co-authored-by: @nkish <19225359+ankishb@users.noreply.github.com> Co-authored-by: Pulkit Mehta <pulkit_mehta_work@yahoo.com> Co-authored-by: David Breuer <DavidBreuer@users.noreply.github.com> Co-authored-by: Niklas <niklas.sm+github@gmail.com> Co-authored-by: Windber <guolipengyeah@126.com> Co-authored-by: Stephen Blystone <29995339+blynotes@users.noreply.github.com> Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>

harini-sridhar and others added 4 commits November 2, 2019 11:48

Added Sphinx versionadded to TimeSeriesSplit docstring (Issue #15426)

a3e6d43

Added Sphinx versionadded to docstrings of PLSCanonical, PLSRegressio…

baccef5

…n, PLSSVD, PatchExtractor, Pipeline, PowerTransformer, PredefinedSplit (Issue #15426)

moving 'versionadded' to before parameters section

9b072d3

fixed flake8 whitespace errors

bc0310e

Merge branch 'master' of https://github.com/scikit-learn/scikit-learn …

864f93f

…into docs_version_added

glemaitre requested changes Dec 10, 2019

View reviewed changes

glemaitre changed the title ~~Docs version added~~ [MRG] DOC add versionadded directive to some estimators Dec 10, 2019

Reshama added 2 commits December 10, 2019 12:00

Merge branch 'master' of https://github.com/scikit-learn/scikit-learn …

ea698b2

…into docs_version_added

removed/added blank lines

a552521

glemaitre reviewed Dec 10, 2019

View reviewed changes

Reshama added 2 commits December 10, 2019 15:37

Merge branch 'master' of https://github.com/scikit-learn/scikit-learn …

6a80b54

…into docs_version_added

adding/removing lines

7367fa8

glemaitre reviewed Dec 10, 2019

View reviewed changes

Merge branch 'master' of https://github.com/scikit-learn/scikit-learn …

216953d

…into docs_version_added

reshamas requested a review from glemaitre December 12, 2019 17:24

Reshama added 5 commits December 16, 2019 08:51

Merge branch 'master' of https://github.com/scikit-learn/scikit-learn …

cba2f3f

…into docs_version_added

?chg to _pls.py

407b49f

added blank line

2af4730

remembered to save/commit changes this time

200d78e

Merge branch 'master' of https://github.com/scikit-learn/scikit-learn …

ef23e73

…into docs_version_added

glemaitre merged commit cc8d2d2 into scikit-learn:master Dec 19, 2019

glemaitre removed their request for review December 19, 2019 13:07

reshamas deleted the docs_version_added branch December 20, 2019 01:22

ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Dec 31, 2019

DOC add versionadded directive to some estimators (scikit-learn#15849)

6f147b1

ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Jan 2, 2020

DOC add versionadded directive to some estimators (scikit-learn#15849)

4676789

panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020

DOC add versionadded directive to some estimators (scikit-learn#15849)

2375cb3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MRG] DOC add versionadded directive to some estimators #15849

[MRG] DOC add versionadded directive to some estimators #15849

reshamas commented Dec 9, 2019

reshamas commented Dec 9, 2019

glemaitre commented Dec 10, 2019 •

edited

Loading

reshamas commented Dec 10, 2019

glemaitre commented Dec 10, 2019

glemaitre left a comment

glemaitre Dec 10, 2019

glemaitre Dec 10, 2019

glemaitre Dec 10, 2019

glemaitre Dec 10, 2019

glemaitre Dec 10, 2019

glemaitre Dec 10, 2019

glemaitre Dec 10, 2019

glemaitre Dec 10, 2019

glemaitre Dec 10, 2019

glemaitre Dec 10, 2019

glemaitre left a comment

glemaitre Dec 10, 2019

glemaitre Dec 10, 2019

glemaitre Dec 10, 2019

glemaitre Dec 10, 2019

glemaitre Dec 10, 2019

glemaitre Dec 10, 2019

glemaitre Dec 10, 2019

glemaitre Dec 10, 2019

reshamas commented Dec 10, 2019

glemaitre left a comment

glemaitre Dec 10, 2019

glemaitre Dec 10, 2019

glemaitre Dec 10, 2019

glemaitre Dec 10, 2019

glemaitre Dec 10, 2019

glemaitre Dec 10, 2019

reshamas commented Dec 11, 2019

glemaitre commented Dec 19, 2019

		@@ -2739,6 +2741,7 @@ class PowerTransformer(TransformerMixin, BaseEstimator):

		.. [2] G.E.P. Box and D.R. Cox, "An Analysis of Transformations", Journal
		of the Royal Statistical Society B, 26, 211-252 (1964).

@@ @@ -791,6 +795,7 @@ class PLSCanonical(_PLS): @@
                   --------
                   CCA
                   PLSSVD

[MRG] DOC add versionadded directive to some estimators #15849

[MRG] DOC add versionadded directive to some estimators #15849

Conversation

reshamas commented Dec 9, 2019

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

reshamas commented Dec 9, 2019

glemaitre commented Dec 10, 2019 • edited Loading

reshamas commented Dec 10, 2019

glemaitre commented Dec 10, 2019

glemaitre left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

glemaitre left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

reshamas commented Dec 10, 2019

glemaitre left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

reshamas commented Dec 11, 2019

glemaitre commented Dec 19, 2019

glemaitre commented Dec 10, 2019 •

edited

Loading