WIP FIX Revert changes in check_is_fitted #15885
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15845 revert #14545
Some users complain about the new check_is_fitted and I prefer to revert the change.
The core issue is that some estimators (e.g., TfidfVectorizer) set private attributes in
__init__
and this seems reasonable:We can't simply remove
v.startswith("_")
because some estimators do not create any public attributes in fit (e.g., TfidfTransformer).