From c799a7d283fa1d153a4b87254fbeb4f1cee079ed Mon Sep 17 00:00:00 2001 From: stareh Date: Sat, 25 Jan 2020 11:42:53 +0100 Subject: [PATCH 1/2] added the link for an open pdf of the article --- sklearn/model_selection/_validation.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sklearn/model_selection/_validation.py b/sklearn/model_selection/_validation.py index 9e27ee28005dc..038b6f5e1a0d4 100644 --- a/sklearn/model_selection/_validation.py +++ b/sklearn/model_selection/_validation.py @@ -1039,6 +1039,8 @@ def permutation_test_score(estimator, X, y, groups=None, cv=None, Ojala and Garriga. Permutation Tests for Studying Classifier Performance. The Journal of Machine Learning Research (2010) vol. 11 + http://www.jmlr.org/papers/volume11/ojala10a/ojala10a.pdf + (it is the pdf of the journal) """ X, y, groups = indexable(X, y, groups) From 294f34d6960bc1f3b1b7e486e9b8abea46d97b86 Mon Sep 17 00:00:00 2001 From: Roman Yurchak Date: Mon, 3 Feb 2020 11:06:13 +0100 Subject: [PATCH 2/2] Address comment --- sklearn/model_selection/_validation.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sklearn/model_selection/_validation.py b/sklearn/model_selection/_validation.py index 038b6f5e1a0d4..aaa25e2ab2c25 100644 --- a/sklearn/model_selection/_validation.py +++ b/sklearn/model_selection/_validation.py @@ -1039,8 +1039,7 @@ def permutation_test_score(estimator, X, y, groups=None, cv=None, Ojala and Garriga. Permutation Tests for Studying Classifier Performance. The Journal of Machine Learning Research (2010) vol. 11 - http://www.jmlr.org/papers/volume11/ojala10a/ojala10a.pdf - (it is the pdf of the journal) + `[pdf] `_. """ X, y, groups = indexable(X, y, groups)