BUG Ignores tags when estimator is a class in parametrize_with_checks #16709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't seem natural to me to ignore the tags when we pass a class |
rth
approved these changes
Mar 17, 2020
| # try to construct estimator to get tags, if it is unable to then | ||
| # return the estimator class | ||
| try: | ||
| xfail_checks = _safe_tags(_construct_instance(estimator), |
There was a problem hiding this comment.
_construct_instance is potentially costly, but I also don't see a way around it.
There was a problem hiding this comment.
I'm not concerned given our conventions
jnothman
approved these changes
Mar 18, 2020
This was referenced Apr 23, 2020
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #16707
What does this implement/fix? Explain your changes.
Ignores the tags when estimator is a class in
parametrize_with_checksCC @rth