Skip to content

DOC cleaning up to 0.23/whats new #17015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 27, 2020
Merged

DOC cleaning up to 0.23/whats new #17015

merged 6 commits into from
Apr 27, 2020

Conversation

adrinjalali
Copy link
Member

@adrinjalali adrinjalali commented Apr 23, 2020 •
edited
Loading

Towards #17010.

Cleaning ups to whats_new.

Some cases which need fixes:

Not sure:

Need entry:

@adrinjalali adrinjalali added this to the 0.23 milestone Apr 23, 2020
NicolasHug
NicolasHug reviewed Apr 23, 2020
View reviewed changes
doc/whats_new/v0.23.rst
@@ -483,3 +520,15 @@ Miscellaneous
`~sklearn.base.ClassifierMixin`. This tag is used to ensure that a proper
error message is raised when y was expected but None was passed.
:pr:`16622` by `Nicolas Hug`_.

- |API| Most constructor and function parameters are now expected to be passed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering whether we should have a top-level note for this one? Like we did in 0.22 for the deprecations

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I was thinking about having a dedicated deprecation section too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanna do it? I'm happy to help if needed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it'd be really nice if you did this part.

NicolasHug
NicolasHug approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@adrinjalali maybe we can merge this one right now and address the listed entries in other PRs? This might ease the review given that lots of stuff are moved around in this one

doc/whats_new/v0.23.rst
@@ -483,3 +520,15 @@ Miscellaneous
`~sklearn.base.ClassifierMixin`. This tag is used to ensure that a proper
error message is raised when y was expected but None was passed.
:pr:`16622` by `Nicolas Hug`_.

- |API| Most constructor and function parameters are now expected to be passed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanna do it? I'm happy to help if needed

@adrinjalali
Copy link
Member Author

created #17057. We can merge this one and move forward as you suggest @NicolasHug

@NicolasHug NicolasHug changed the title DOC 0.23/whats new DOC cleaning up to 0.23/whats new Apr 27, 2020
@NicolasHug NicolasHug merged commit f624f4e into scikit-learn:master Apr 27, 2020
@NicolasHug NicolasHug mentioned this pull request Apr 27, 2020
Merged
@adrinjalali adrinjalali deleted the 0.23/whats_new branch April 27, 2020 18:10
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
@adrinjalali @gio8tisu
DOC cleaning up to 0.23/whats new (scikit-learn#17015)
43a7f11
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
@adrinjalali @viclafargue
DOC cleaning up to 0.23/whats new (scikit-learn#17015)
259a605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.23
Development

Successfully merging this pull request may close these issues.
2 participants
@adrinjalali @NicolasHug