Skip to content

DOC Add user guide for permutation_test_score #18055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 13, 2020
Merged

DOC Add user guide for permutation_test_score #18055

merged 5 commits into from
Aug 13, 2020

Conversation

lucyleeow
Copy link
Member

Reference Issues/PRs

Follows on from #17373 and #10905

What does this implement/fix? Explain your changes.

Add user guide for permutation_test_score

Any other comments?

cc @ogrisel

@lucyleeow
Copy link
Member Author

lucyleeow commented Aug 1, 2020 •
edited
Loading

(Also) Should the example plot_permutation_test_for_classification.py by under the 'feature selection' heading? Wouldn't 'model selection' be better?

swierh
swierh suggested changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@swierh swierh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be a bit more explicit about that this test only shows that the model reliably outperforms random guessing.

@ogrisel
Copy link
Member

ogrisel commented Aug 5, 2020

(Also) Should the example plot_permutation_test_for_classification.py by under the 'feature selection' heading? Wouldn't 'model selection' be better?

It's true that it would make more sense to move it under model selection but it would change its URL and break links...

ogrisel
ogrisel reviewed Aug 6, 2020
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Here are a few suggestions for further improvements:

thomasjpfan
thomasjpfan approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 018de22 into scikit-learn:master Aug 13, 2020
@lucyleeow lucyleeow deleted the doc_permts branch August 14, 2020 09:43
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
@lucyleeow @jayzed82
DOC Add user guide for permutation_test_score (scikit-learn#18055)
534bb20 
* wip

* add user guide

* fix link to ex

* suggestion

* suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@swierh swierh swierh approved these changes

Assignees
No one assigned
Labels
module:model_selection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucyleeow @ogrisel @thomasjpfan @swierh