FIX make it possible to specify the positive label in roc_auc_score #18107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
reviewed
Aug 6, 2020
| average_precision_score, needs_threshold=True, | ||
| ) | ||
| with pytest.raises(ValueError): | ||
| average_precision_scorer(classifier, X_test, y_test) |
There was a problem hiding this comment.
Please also check the message to make the test easier to follow.
ogrisel
reviewed
Aug 6, 2020
|
|
||
| pos_label = "cancer" | ||
| y_proba = y_proba[:, 0] | ||
| y_decision_function *= -1 |
There was a problem hiding this comment.
Maybe add a line such as:
assert classifier.classes_[0] == pos_labelto make the test easier to follow.
|
OK, so it seems that I figure out some of the stuffs. I will close all my PRs and open the following:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17572
closes #17704