ENH Adds plot_det_curve and associated display #18176
Conversation
|
ping @thomasjpfan @lorentzenchr @agramfort I renamed the function and added the plotting utilities. |
There was a problem hiding this comment.
Overall it looks very good. I've two open questions:
- What about adding an optional argument to switch off/on the Normal transformed scale (call to
sp.stats.norm.ppf) ? - The tests are mostly copy&past from tests of
plot_roc_curve. Could we elegantly avoid this duplication?
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
I think this is one of the properties of the DET curve. I am not sure that we should propose a parameter. We could be conservative at first releasing without his feature and see if there is a need for it. |
This should be possible :) |
|
Only the test specific to each curve is not tested commonly because it might be easier to discover and understand what is happening at the cost of being slightly redundant. |
| if "label" in line_kwargs: | ||
| ax.legend(loc="lower right") | ||
|
|
||
| ticks = [0.001, 0.01, 0.05, 0.20, 0.5, 0.80, 0.95, 0.99, 0.999] |
There was a problem hiding this comment.
Should these ticks be user adjustable?
There was a problem hiding this comment.
I would say this is a good default. Then we return ax so the user can customize it.
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Add the plotting helpers for the DET curve
Follow-up to #18169
Closes #18181