Skip to content

[MRG] Added missing self argument to the abstract method "fit" #18971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2020
Merged

[MRG] Added missing self argument to the abstract method "fit" #18971

merged 1 commit into from
Dec 11, 2020

Conversation

novaya
Copy link
Contributor

@novaya novaya commented Dec 6, 2020

What does this implement/fix? Explain your changes.

Added missing self to the fit method

thomasjpfan
thomasjpfan approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @novaya !

LGTM

@amueller
Copy link
Member

LGTM

@amueller amueller merged commit 8ebb614 into scikit-learn:master Dec 11, 2020
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Dec 22, 2020
@novaya @glemaitre
Added self to abstract fit method (scikit-learn#18971)
fdb4142
@glemaitre glemaitre mentioned this pull request Dec 22, 2020
Merged
14 tasks
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
module:decomposition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@novaya @amueller @thomasjpfan