From 9f2cb473d99fc31affdcb55a83985ccbe1ce9cea Mon Sep 17 00:00:00 2001 From: Brian Rice Date: Wed, 16 Dec 2020 16:08:38 -0600 Subject: [PATCH 1/2] Specify that alphas must be strictly positive for RidgeCV Make it more clear that alphas of zero are not allowed. --- sklearn/linear_model/_ridge.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sklearn/linear_model/_ridge.py b/sklearn/linear_model/_ridge.py index 199a1cd760660..f3f1074312f60 100644 --- a/sklearn/linear_model/_ridge.py +++ b/sklearn/linear_model/_ridge.py @@ -1466,7 +1466,7 @@ def fit(self, X, y, sample_weight=None): if np.any(self.alphas <= 0): raise ValueError( - "alphas must be positive. Got {} containing some " + "alphas must be strictly positive. Got {} containing some " "negative or null value instead.".format(self.alphas)) X, y, X_offset, y_offset, X_scale = LinearModel._preprocess_data( From 6f1b9a14d89be5c4c6d560c7d0f0b4462de1cfc3 Mon Sep 17 00:00:00 2001 From: Brian Rice Date: Wed, 16 Dec 2020 16:17:41 -0600 Subject: [PATCH 2/2] Update corresponding tests for RidgeCV alphas --- sklearn/linear_model/tests/test_ridge.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sklearn/linear_model/tests/test_ridge.py b/sklearn/linear_model/tests/test_ridge.py index 7d52de903aee5..2da9a60fb301e 100644 --- a/sklearn/linear_model/tests/test_ridge.py +++ b/sklearn/linear_model/tests/test_ridge.py @@ -1126,13 +1126,13 @@ def test_ridgecv_negative_alphas(): # Negative integers ridge = RidgeCV(alphas=(-1, -10, -100)) assert_raises_regex(ValueError, - "alphas must be positive", + "alphas must be strictly positive", ridge.fit, X, y) # Negative floats ridge = RidgeCV(alphas=(-0.1, -1.0, -10.0)) assert_raises_regex(ValueError, - "alphas must be positive", + "alphas must be strictly positive", ridge.fit, X, y)