CI Publish to Pypi workflow for aarch64 wheels #19060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfaro96
approved these changes
Dec 22, 2020
|
I have been testing this script locally by running: rm -rf dist
python -m wheelhouse_uploader fetch \
--version 0.24.0 \
--local-folder dist/ \
scikit-learn \
https://pypi.anaconda.org/scikit-learn-wheels-staging/simple/scikit-learn/
python build_tools/github/check_wheels.py |
|
I already pushed the following to master to upload the wheels for the 0.24.0 release: ae3c48c |
|
I would be in favor of merging this PR but it needs to undo the change of ae3c48c. |
+1 for this PR too. |
|
Let's wait for the 0.24.0 doc build on circle CI to complete before merging a PR to master: https://app.circleci.com/pipelines/github/scikit-learn/scikit-learn This is to avoid a git race condition between circle ci runs on the 0.24.X vs master branch when deploying the new website. |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Jan 18, 2021
jeremiedbb
pushed a commit
that referenced
this pull request
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #19058
What does this implement/fix? Explain your changes.
Updates the "Publish to Pypi" workflow so that it counts the aarch64 builds from the travis config.
This only needs to be merged with master. Then we can trigger the workflow to upload to
testpypiand thenpypi.